Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8E331429E27 for ; Wed, 14 Dec 2011 04:17:57 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a5m0KbMX1QL5 for ; Wed, 14 Dec 2011 04:17:56 -0800 (PST) Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 6E7B2429E26 for ; Wed, 14 Dec 2011 04:17:56 -0800 (PST) Received: from pps.filterd (mail-gw3 [127.0.0.1]) by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBECFJmQ029996; Wed, 14 Dec 2011 14:17:42 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by mail-gw3.nixu.fi with ESMTP id 114cs0t9ep-1 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Wed, 14 Dec 2011 14:17:41 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id pBECHfnl015798; Wed, 14 Dec 2011 14:17:41 +0200 From: Tomi Ollila To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org Subject: Re: [PATCH 3/7] py3k: All strings are unicode strings in py3k In-Reply-To: <1323860305-15802-4-git-send-email-4winter@informatik.uni-hamburg.de> References: <1323860305-15802-1-git-send-email-4winter@informatik.uni-hamburg.de> <1323860305-15802-4-git-send-email-4winter@informatik.uni-hamburg.de> User-Agent: Notmuch/0.10.2+93~g631d290 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2011-12-14_05:2011-12-14, 2011-12-14, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1112140071 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2011 12:17:57 -0000 On Wed, 14 Dec 2011 11:58:21 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote: > --- > bindings/python/notmuch/globals.py | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bindings/python/notmuch/globals.py b/bindings/python/notmuch/globals.py > index 54a49b2..99e6a10 100644 > --- a/bindings/python/notmuch/globals.py > +++ b/bindings/python/notmuch/globals.py > @@ -51,7 +51,7 @@ class Status(Enum): > """Get a (unicode) string representation of a notmuch_status_t value.""" > # define strings for custom error messages > if status == STATUS.NOT_INITIALIZED: > - return u"Operation on uninitialized object impossible." > + return "Operation on uninitialized object impossible." > return unicode(Status._status2str(status)) > > STATUS = Status(['SUCCESS', > @@ -142,7 +142,7 @@ class NotmuchError(Exception): > elif self.status is not None: > return STATUS.status2str(self.status) > else: > - return u'Unknown error' > + return 'Unknown error' Is this u -prefix unnecessary in python 2 too ? Grepping 'u"' and "u'" in **/*.py in puthon bindings source resulted some more u-prefixed strings in docs/source/conf.py. Should these be changed in some future patch ? > # List of Subclassed exceptions that correspond to STATUS values and are > -- > 1.7.7.3 Tomi