From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: use 'gnus-decoded in
	notmuch-mm-display-part-inline ()
In-Reply-To: <1337533094-5467-1-git-send-email-tomi.ollila@iki.fi>
References: <1337533094-5467-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.13+14~g2d2a5a4 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Wed, 23 May 2012 12:20:21 +0200
Message-ID: <87obpfurkq.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Precedence: list

Tomi Ollila <tomi.ollila@iki.fi> writes:
> When mail message is read from emacs, the message structure
> obtained may contain parts which have content included
> (`text/plain` for example) and other parts where content is not
> included (`text/html` for example).
>
> In case content is included, the string is already available in
> emacs' internal format and therefore mm-... functions should not
> attempt to do further decoding for the data in temp buffer
> provided for it.
>
> Currently when reply buffer is created,
> notmuch-mm-display-part-inline () is used to provided quoted reply
> content. This change makes the mm-... functions called by it use
> 'gnus-decoded as charset whenever the content is already available.
>
> File .../emacs-23.3/lisp/gnus/mm-uu.el mentions:
> "`gnus-decoded' is a fake charset, which means no further decoding."
> ---
>
> I propose this patch is taken into 0.13.1.

LGTM. I use it in my private branch. The bug fixed by this patch is
really annoying.

>
> Please note that I'm not entirely sure my description above
> is right. So those who knows more of these issues please check
> my "facts".

Your description matches with what I found in
id:"871umc1int.fsf@steelpick.2x.cz".


Thanks,
-Michal