From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: use notmuch-start-notmuch
In-Reply-To: <m2zju2lqpy.fsf@guru.guru-group.fi>
References: <1372921788-16042-1-git-send-email-markwalters1009@gmail.com>
	<m2zju2lqpy.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1
	(i486-pc-linux-gnu)
Date: Thu, 04 Jul 2013 09:07:24 +0100
Message-ID: <87ip0qg343.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


Tomi Ollila <tomi.ollila@iki.fi> writes:

> FWIW the code LGTM. Do the pick tests use this and do those pass ?

Thanks for the review.

The tests do all pass. There are two sets of pick tests: one uses the
async parser (the default) which uses this code and the other uses the
sync parser (which probably should be removed as the async parser seems
stable).

Best wishes

Mark






>
> Tomi
>
>>
>> Best wishes
>>
>> Mark
>>
>>
>>  contrib/notmuch-pick/notmuch-pick.el |    7 +++----
>>  1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
>> index fbd7c0b..7f5f729 100644
>> --- a/contrib/notmuch-pick/notmuch-pick.el
>> +++ b/contrib/notmuch-pick/notmuch-pick.el
>> @@ -817,16 +817,15 @@ Complete list of currently available key bindings:
>>      (if (equal (car (process-lines notmuch-command "count" search-args)) "0")
>>  	(setq search-args basic-query))
>>      (if notmuch-pick-asynchronous-parser
>> -	(let ((proc (start-process
>> -		     "notmuch-pick" buffer
>> -		     notmuch-command "show" "--body=false" "--format=sexp"
>> +	(let ((proc (notmuch-start-notmuch
>> +		     "notmuch-pick" buffer #'notmuch-pick-process-sentinel
>> +		     "show" "--body=false" "--format=sexp"
>>  		     message-arg search-args))
>>  	      ;; Use a scratch buffer to accumulate partial output.
>>                ;; This buffer will be killed by the sentinel, which
>>                ;; should be called no matter how the process dies.
>>                (parse-buf (generate-new-buffer " *notmuch pick parse*")))
>>            (process-put proc 'parse-buf parse-buf)
>> -	  (set-process-sentinel proc 'notmuch-pick-process-sentinel)
>>  	  (set-process-filter proc 'notmuch-pick-process-filter)
>>  	  (set-process-query-on-exit-flag proc nil))
>>        (progn
>> -- 
>> 1.7.9.1
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch