Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D54BF431FD0 for ; Thu, 2 Dec 2010 08:38:06 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xXIqsUrR0THP for ; Thu, 2 Dec 2010 08:38:06 -0800 (PST) Received: from everglades.pioto.org (mail.pioto.org [207.192.71.235]) by olra.theworths.org (Postfix) with ESMTP id 7D360431FB5 for ; Thu, 2 Dec 2010 08:38:06 -0800 (PST) Received: by everglades.pioto.org (Postfix, from userid 1000) id 1FA711611E4; Thu, 2 Dec 2010 11:38:06 -0500 (EST) Date: Thu, 2 Dec 2010 11:38:06 -0500 From: Mike Kelly To: notmuch@notmuchmail.org Subject: Re: [PATCH] test: change "#!/bin/bash" to "#!/usr/bin/env bash" enhances portability Message-ID: <20101202163806.GA13069@everglades.pioto.org> References: <1291235272-16335-1-git-send-email-joel.borggren.franck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1291235272-16335-1-git-send-email-joel.borggren.franck@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2010 16:38:07 -0000 On Wed, Dec 01, 2010 at 09:27:52PM +0100, Joel Borggrén-Franck wrote: > From: Joel Borggrén-Franck > > Change #!/bin/bash at start of tests to "#!/usr/bin/env bash". That way > systems running on bash < 4 can prepend bash >= 4 to path before > running the tests. This is also important on systems where bash isn't in /bin/ (for example, FreeBSD), so I'd appreciate this patch. (I'm slowly working on various other patches that are required to get things working well on FreeBSD). -- Mike Kelly