Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 810E2429E44 for ; Sat, 15 Mar 2014 11:25:02 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mdhtmVtW2WGt for ; Sat, 15 Mar 2014 11:24:57 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id CC1F8429E26 for ; Sat, 15 Mar 2014 11:24:57 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1WOtGO-0003y1-JS; Sat, 15 Mar 2014 15:24:52 -0300 Received: (nullmailer pid 15441 invoked by uid 1000); Sat, 15 Mar 2014 18:24:48 -0000 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v2] util: Fix two corner-cases in boolean term quoting function In-Reply-To: <1394570520-23279-1-git-send-email-amdragon@mit.edu> References: <1394570520-23279-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.17+133~g5348d19 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 15 Mar 2014 15:24:48 -0300 Message-ID: <874n2zqpzj.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Mar 2014 18:25:02 -0000 Austin Clements writes: > Previously, make_boolean_term did not quote empty boolean terms or > boolean terms that started with '('. These cases are incompatible > with Xapian: empty terms cannot be omitted, and boolean terms that > start with '(' trigger an alternate term quoting syntax. pushed, d