From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Jinwoo Lee <jinwoo68@gmail.com>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] Add a defcustom for whether to block remote images by
	default.
In-Reply-To: <87pp9yjbhw.fsf@maritornes.cs.unb.ca>
References: <1422495572-40384-1-git-send-email-jinwoo68@gmail.com>
	<87pp9yjbhw.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 29 Jan 2015 10:58:14 +0200
Message-ID: <m2sieut13t.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Thu, Jan 29 2015, David Bremner <david@tethera.net> wrote:

> Jinwoo Lee <jinwoo68@gmail.com> writes:
>
>> +	(shr-blocked-images (if notmuch-show-block-remote-images
>> +				"."
>> +			      shr-blocked-images)))
>>      (shr-insert-document dom)
>>      t))
>
> Ideally such a customization would apply to all html renders. I think
> Tomi did some experiments with w3m and friends, I _think_ they respect
> gnus-blocked-images, but maybe Tomi can comment.

I did M-x debug-on-entry RET open-network-stream RET  (or an equivalent of
t that in elisp, but the code I did is now lost & forgotten ;/

The docstring relevant to the renderers below it at the end of this email.

'gnus-w3m respect gnus-blocked-images

I could not run 'w3m on that system... nor 'w3

There was no effect with 'w3m-standalone -- in this case I'd think it is up
to w3m binary to load external stuff or not. I presume the same is the
case with 'links, 'lynx, 'html2text and nil

So, to add to David's suggestion maybe just set both gnus-blocked-images
and shr-blocked-images to the value of notmuch-show-text/html-blocked-images


Tomi


mm-text-html-renderer is a variable defined in `mm-decode.el'.
Its value is shr

Documentation:
Render of HTML contents.
It is one of defined renderer types, or a rendering function.
The defined renderer types are:
`shr': use the built-in Gnus HTML renderer;
`gnus-w3m': use Gnus renderer based on w3m;
`w3m': use emacs-w3m;
`w3m-standalone': use plain w3m;
`links': use links;
`lynx': use lynx;
`w3': use Emacs/W3;
`html2text': use html2text;
nil    : use external viewer (default web browser).


> d