DomainKey-Signature: a=rsa-sha1; c=nofws; d=maillard.im; h=from:to
	:subject:in-reply-to:references:reply-to:date:message-id
	:mime-version:content-type; q=dns; s=postfix; b=YIspDPo1ksfUTfjK
	O1iOPS5YwZeZN2wVamHSm0lZ5SKupIi42RP9eS7veOhq9xZ/4ml2LvLflIWZzme0
	EzqUSS2HGOF//RrT3t1Mmyo+eSfcn8bV46MgaTOyNdVOZUwRwIpjRTCiOs85GvZw
	SNnK5MD+ZfWxOENkKK2NpBbWG4Q=
From: Xavier Maillard <xavier@maillard.im>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Ignore encrypted parts when indexing.
In-Reply-To: <1325005901-21374-1-git-send-email-jrollins@finestructure.net>
References: <1325005901-21374-1-git-send-email-jrollins@finestructure.net>
User-Agent: Notmuch/0.10.1 (http://notmuchmail.org) Emacs/23.2.1
	(i486-slackware-linux-gnu)
Date: Wed, 28 Dec 2011 13:40:42 +0100
Message-ID: <m2y5twc1it.fsf@kcals.intra.maillard.im>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list
Reply-To: Xavier Maillard <xma@gnu.org>

Hi Jameson,

On Tue, 27 Dec 2011 09:11:41 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> It appears to be an oversight that encrypted parts were indexed
> previously.  The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database.  It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.

+1 for this.

But,

> +	    if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
> +		/* Don't index encrypted parts. */
> +		continue

This needs a semicolon, doesn't it ?

/Xavier