From: Pieter Praet <pieter@praet.org>
To: Mark Walters <markwalters1009@gmail.com>,
	Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions
In-Reply-To: <874nvric7c.fsf@qmul.ac.uk>
References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
	<1327000744-25463-1-git-send-email-pieter@praet.org>
	<20120119193647.GN16740@mit.edu> <87pqef4fuk.fsf@qmul.ac.uk>
	<m24nvr4fdc.fsf@wal122.wireless-pennnet.upenn.edu>
	<87zkdjmofb.fsf@qmul.ac.uk> <20120119202839.GQ16740@mit.edu>
	<874nvric7c.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.11+99~gab86e73 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 19 Jan 2012 23:44:36 +0100
Message-ID: <87ty3ruxbf.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>, Aaron Ecay <ecay@sas.upenn.edu>
Precedence: list

On Thu, 19 Jan 2012 22:01:27 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> 
> > > I am happy with them appearing as a non matching message, but currently
> > > they appear as a full open message. (The patch to achieve this is
> > > trivial: essentially transpose part of Austin's patch of
> > > notmuch-search.c into notmuch-show.c)
> > 
> > This definitely sounds like the right thing to do.  We can argue about
> > more sophisticated UIs, but it should do this at a minimum.
> 
> I will post the trivial patch in a moment (trivial but I could easily
> have done something stupid).
> 
> I haven't written a test yet: should it have one, [...]

That would be preferrable, yes.

> [...] and if so, could
> someone point me to the appropriate place to put it?
> 

In "test/emacs", right after "Hiding message with visible citation in
notmuch-show view" would be perfect IMO.

As you can see, that test uses `test-visible-output', which should
provide the functionality you need.

> Best wishes
> 
> Mark


Thanks!


Peace

-- 
Pieter