Return-Path: <cworth@cworth.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 9CC9D431FBF;
	Sun, 22 Nov 2009 20:35:08 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id CgWJq-42yES0; Sun, 22 Nov 2009 20:35:07 -0800 (PST)
Received: from cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 63ADE431FAE;
	Sun, 22 Nov 2009 20:35:07 -0800 (PST)
From: Carl Worth <cworth@cworth.org>
To: "Jeffrey C. Ollie" <jeff@ocjtech.us>, Not Much Mail
	<notmuch@notmuchmail.org>
In-Reply-To: <1258924631-17326-1-git-send-email-jeff@ocjtech.us>
References: <1258924631-17326-1-git-send-email-jeff@ocjtech.us>
Date: Mon, 23 Nov 2009 05:34:53 +0100
Message-ID: <87ljhxg8pe.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [notmuch] [PATCH] Add install target for desktop files.
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Nov 2009 04:35:08 -0000

On Sun, 22 Nov 2009 15:17:11 -0600, "Jeffrey C. Ollie" <jeff@ocjtech.us> wrote:
> Add an install target that uses desktop-file-install to install the
> desktop file in the appropriate location.  The location of the install
> can be modified by changing the desktop_dir variable.

Hi Jeffrey,

I suppose if we're going to have a .desktop file it only makes sense to
install it. A couple of questions:

> +install-desktop:
> +	install -d $(DESTDIR)$(desktop_dir)
> +	desktop-file-install --mode 0644 --dir $(DESTDIR)$(desktop_dir) notmuch.desktop

What does desktop-file-install do for us here? Anything that we couldn't
do with just "install"? I'm just wanting to be careful that we don't
break "make install" for people who may not even want this file.

If we really do need to install it with desktop-file-install, we could
do a configure check for that program, of course.

Thanks,

-Carl