Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DE2064196F4 for ; Thu, 22 Apr 2010 15:20:39 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dln5+rk4J6t7 for ; Thu, 22 Apr 2010 15:20:39 -0700 (PDT) Received: from mail-pv0-f181.google.com (mail-pv0-f181.google.com [74.125.83.181]) by olra.theworths.org (Postfix) with ESMTP id 1BC5A4196F2 for ; Thu, 22 Apr 2010 15:20:39 -0700 (PDT) Received: by pvg3 with SMTP id 3so1488936pvg.26 for ; Thu, 22 Apr 2010 15:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=31btXKdpal0D3bhBnoterT6SR+qvDZK5f/Np1JDJADY=; b=Jd4FaELBZ3wNCyhXrrL2PHtaoSUEzam3WPq9yFGBtY4Jvg8/mYgHduk1w2Yl0MzyHz Qv+uY3XhSSgU+VOfpiO9YJsnB2HuzU42lFSyL3vEKbNcao0FCciOllyY7JdDhcpA7lo/ yJv7xgRtIvkkqJ0hvAKIXKOMOSd4QqLjpQqj0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=MnCIdFQbRMfQvepmt6i3niWhAtKM7D0rQnr3hW578/FF5I9L++0fxrZhxUTe4Zec93 cKOGjgONzL4UHwKqwQW0XSQACY5lxvqHtnuSpTevh6BeOk0BL0V0ic5Sf+MRiJgoZPmC WC3INHeLlspDKsfzfU8bngE+yq28UYTeIWVlA= Received: by 10.142.149.39 with SMTP id w39mr332424wfd.61.1271974838231; Thu, 22 Apr 2010 15:20:38 -0700 (PDT) Received: from localhost.localdomain (physnat56.physics.umass.edu [128.119.50.56]) by mx.google.com with ESMTPS id v41sm182194wfh.21.2010.04.22.15.20.36 (version=SSLv3 cipher=RC4-MD5); Thu, 22 Apr 2010 15:20:37 -0700 (PDT) From: Ben Gamari To: notmuch Subject: [PATCH] Fix linker error from insufficient LDFLAGS Date: Thu, 22 Apr 2010 18:20:27 -0400 Message-Id: <1271974827-10978-2-git-send-email-bgamari.foss@gmail.com> X-Mailer: git-send-email 1.7.0.5 In-Reply-To: <1271974827-10978-1-git-send-email-bgamari.foss@gmail.com> References: <1271974827-10978-1-git-send-email-bgamari.foss@gmail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2010 22:20:40 -0000 It seems that LDFLAGS have recently been reorganized, along with the introduction of a notmuch-shared rule. Unfortunately, the LDFLAGS used in notmuch-shared don't include CONFIGURE_LDFLAGS. This caused linking to fail with the following, $ make V=1 gcc debugger.o gmime-filter-reply.o gmime-filter-headers.o notmuch.o notmuch-config.o notmuch-count.o notmuch-dump.o notmuch-new.o notmuch-reply.o notmuch-restore.o notmuch-search.o notmuch-search-tags.o notmuch-setup.o notmuch-show.o notmuch-tag.o notmuch-time.o query-string.o show-message.o json.o -Llib -lnotmuch -o notmuch-shared /usr/bin/ld: gmime-filter-reply.o: undefined reference to symbol 'g_mime_filter_set_size' /usr/bin/ld: note: 'g_mime_filter_set_size' is defined in DSO //usr/lib64/libgmime-2.4.so.2 so try adding it to the linker command line //usr/lib64/libgmime-2.4.so.2: could not read symbols: Invalid operation collect2: ld returned 1 exit status make: *** [notmuch-shared] Error 1 --- Makefile.local | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index 5bb570b..33b8213 100644 --- a/Makefile.local +++ b/Makefile.local @@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc # Smash together user's values with our extra values FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS) $(CONFIGURE_CFLAGS) $(extra_cflags) FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch $(CONFIGURE_LDFLAGS) FINAL_NOTMUCH_LINKER = CC ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1) FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS) -- 1.7.0.5