Date: Wed, 11 Jan 2012 22:50:32 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH v3 4/4] test: add tests for "notmuch reply"
	--reply-to=sender
Message-ID: <20120112035032.GV20796@mit.edu>
References: <cover.1325794371.git.jani@nikula.org>
	<cover.1326224339.git.jani@nikula.org>
	<33b8a00a073d39baeecc86b8b8f97683d2cec3c0.1326224339.git.jani@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To:
 <33b8a00a073d39baeecc86b8b8f97683d2cec3c0.1326224339.git.jani@nikula.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

I'm not sure what the point of the last test is, but this patch
covered everything I could think of, so LGTM.

Quoth Jani Nikula on Jan 10 at  9:54 pm:
> From: Mark Walters <markwalters1009@gmail.com>
> 
> ---
>  test/notmuch-test    |    1 +
>  test/reply-to-sender |  209 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 210 insertions(+), 0 deletions(-)
>  create mode 100755 test/reply-to-sender
> 
> diff --git a/test/notmuch-test b/test/notmuch-test
> index e40ef86..6a99ae3 100755
> --- a/test/notmuch-test
> +++ b/test/notmuch-test
> @@ -33,6 +33,7 @@ TESTS="
>    thread-naming
>    raw
>    reply
> +  reply-to-sender
>    dump-restore
>    uuencode
>    thread-order
> diff --git a/test/reply-to-sender b/test/reply-to-sender
> new file mode 100755
> index 0000000..c7d15bb
> --- /dev/null
> +++ b/test/reply-to-sender
> @@ -0,0 +1,209 @@
> +#!/usr/bin/env bash
> +test_description="\"notmuch reply --reply-to=sender\" in several variations"
> +. ./test-lib.sh
> +
> +test_begin_subtest "Basic reply-to-sender"
> +add_message '[from]="Sender <sender@example.com>"' \
> +             [to]=test_suite@notmuchmail.org \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="basic reply-to-sender test"'
> +
> +output=$(notmuch reply --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Sender <sender@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Sender <sender@example.com> wrote:
> +> basic reply-to-sender test"
> +
> +test_begin_subtest "From Us, Basic reply to message"
> +add_message '[from]="Notmuch Test Suite <test_suite@notmuchmail.org>"' \
> +            '[to]="Recipient <recipient@example.com>"' \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="basic reply-to-from-us test"'
> +
> +output=$(notmuch reply --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Recipient <recipient@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
> +> basic reply-to-from-us test"
> +
> +test_begin_subtest "Multiple recipients"
> +add_message '[from]="Sender <sender@example.com>"' \
> +            '[to]="test_suite@notmuchmail.org, Someone Else <someone@example.com>"' \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="Multiple recipients"'
> +
> +output=$(notmuch reply  --reply-to=sender  id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Sender <sender@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Sender <sender@example.com> wrote:
> +> Multiple recipients"
> +
> +test_begin_subtest "From Us, Multiple TO recipients"
> +add_message '[from]="Notmuch Test Suite <test_suite@notmuchmail.org>"' \
> +            '[to]="Recipient <recipient@example.com>, Someone Else <someone@example.com>"' \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="From Us, Multiple TO recipients"'
> +
> +output=$(notmuch reply  --reply-to=sender  id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Recipient <recipient@example.com>, Someone Else <someone@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
> +> From Us, Multiple TO recipients"
> +
> +test_begin_subtest "Reply with CC"
> +add_message '[from]="Sender <sender@example.com>"' \
> +             [to]=test_suite@notmuchmail.org \
> +            '[cc]="Other Parties <cc@example.com>"' \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="reply with CC"'
> +
> +output=$(notmuch reply  --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Sender <sender@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Sender <sender@example.com> wrote:
> +> reply with CC"
> +
> +test_begin_subtest "From Us, Reply with CC"
> +add_message '[from]="Notmuch Test Suite <test_suite@notmuchmail.org>"' \
> +            '[to]="Recipient <recipient@example.com>"' \
> +            '[cc]="Other Parties <cc@example.com>"' \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="reply with CC"'
> +
> +output=$(notmuch reply  --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Recipient <recipient@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
> +> reply with CC"
> +
> +test_begin_subtest "From Us, Reply no TO but with CC"
> +add_message '[from]="Notmuch Test Suite <test_suite@notmuchmail.org>"' \
> +            '[cc]="Other Parties <cc@example.com>"' \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="reply with CC"'
> +
> +output=$(notmuch reply  --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +Cc: Other Parties <cc@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
> +> reply with CC"
> +
> +test_begin_subtest "Reply from alternate address"
> +add_message '[from]="Sender <sender@example.com>"' \
> +             [to]=test_suite_other@notmuchmail.org \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="reply from alternate address"'
> +
> +output=$(notmuch reply  --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite_other@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Sender <sender@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Sender <sender@example.com> wrote:
> +> reply from alternate address"
> +
> +test_begin_subtest "Support for Reply-To"
> +add_message '[from]="Sender <sender@example.com>"' \
> +             [to]=test_suite@notmuchmail.org \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="support for reply-to"' \
> +            '[reply-to]="Sender <elsewhere@example.com>"'
> +
> +output=$(notmuch reply  --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Sender <elsewhere@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Sender <sender@example.com> wrote:
> +> support for reply-to"
> +
> +test_begin_subtest "Support for Reply-To with multiple recipients"
> +add_message '[from]="Sender <sender@example.com>"' \
> +            '[to]="test_suite@notmuchmail.org, Someone Else <someone@example.com>"' \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="support for reply-to with multiple recipients"' \
> +            '[reply-to]="Sender <elsewhere@example.com>"'
> +
> +output=$(notmuch reply  --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Sender <elsewhere@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Sender <sender@example.com> wrote:
> +> support for reply-to with multiple recipients"
> +
> +test_begin_subtest "Un-munging Reply-To"
> +add_message '[from]="Sender <sender@example.com>"' \
> +            '[to]="Some List <list@example.com>"' \
> +             [subject]=notmuch-reply-test \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="Un-munging Reply-To"' \
> +            '[reply-to]="Evil Munging List <list@example.com>"'
> +
> +output=$(notmuch reply  --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: notmuch-reply-test
> +To: Sender <sender@example.com>
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Sender <sender@example.com> wrote:
> +> Un-munging Reply-To"
> +
> +test_begin_subtest "Message with header of exactly 200 bytes"
> +add_message '[subject]="This subject is exactly 200 bytes in length. Other than its length there is not much of note here. Note that the length of 200 bytes includes the Subject: and Re: prefixes with two spaces"' \
> +            '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
> +            '[body]="200-byte header"'
> +output=$(notmuch reply  --reply-to=sender id:${gen_msg_id})
> +test_expect_equal "$output" "From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +Subject: Re: This subject is exactly 200 bytes in length. Other than its length there is not much of note here. Note that the length of 200 bytes includes the Subject: and Re: prefixes with two spaces
> +In-Reply-To: <${gen_msg_id}>
> +References: <${gen_msg_id}>
> +
> +On Tue, 05 Jan 2010 15:43:56 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
> +> 200-byte header"
> +test_done