From: Carl Worth <cworth@cworth.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <1259329997-sup-2634@broadwater.alporthouse.com>
References: <1258851430-28732-1-git-send-email-chris@chris-wilson.co.uk>
	<87einkqeyt.fsf@yoom.home.cworth.org>
	<1259329997-sup-2634@broadwater.alporthouse.com>
Date: Fri, 27 Nov 2009 21:41:08 -0800
Message-ID: <878wdrtde3.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: [notmuch] [PATCH] notmuch-new: Eliminate tallocs whilst
 construct filenames.
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 27 Nov 2009 14:17:02 +0000, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:
> > I *know* I composed a reply to this message earlier, but apparently
> > you're right that it never went out. (*sigh*---if only I had a reliable
> > mail client[*]).
>=20
> I hear there's one called sup... ;-)

Heh. But seriously, I hit a lot of crashes with sup, and that invariably
led to *lots* of lost tag changes. I'm willing to live with lots of
Xapian-defect-250 pain right now to avoid that lossage.

> The issue I see with the "error, continue" pattern is that we are in
> danger of not reporting the first error but the last one.

OK. That would be a problem, yes.

> Is notmuch ready for fault-injection yet? Maybe once you have a nasty
> testsuite...

It's not "ready" in the sense that there is going to be a huge series of
fixes that fault-injection will find. But it's definitely "ready" in
the sense that I want to start doing this kind of testing.

But yes, we need a test suite.

Oh, and we'll also need to deal with remaining glib usage inside of
notmuch, (and inside of GMime as well), before we can do good testing
for memory-fault injection. Maybe what we'll end up with is a patch to
de-glib-ify GMime? I'm not sure.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLELf06JDdNq8qSWgRAtZzAKCLn1BPm/2tzYxmE1NuqsLcqww/WQCglh/E
4q53sHKqr2CY3N/77SaB0u4=
=62Lt
-----END PGP SIGNATURE-----
--=-=-=--