Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3B312431FBF for ; Wed, 24 Apr 2013 02:30:46 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wPTqkJalwUqr for ; Wed, 24 Apr 2013 02:30:45 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 9C3D5431FB6 for ; Wed, 24 Apr 2013 02:30:45 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 929A81001F0; Wed, 24 Apr 2013 12:30:43 +0300 (EEST) From: Tomi Ollila To: David Bremner , Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org Subject: Re: [PATCH] go: use a different goconfig package In-Reply-To: <87d2tkoo80.fsf@zancas.localnet> References: <1366729987-16925-1-git-send-email-4winter@informatik.uni-hamburg.de> <87d2tkoo80.fsf@zancas.localnet> User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 09:30:46 -0000 On Wed, Apr 24 2013, David Bremner wrote: > Justus Winter <4winter@informatik.uni-hamburg.de> writes: > >> The notmuch-addrlookup utility uses a third party library to read the >> notmuch configuration file. The previously used implementation at >> "github.com/kless/goconfig" vanished, so this patch switches to the >> implementation at "github.com/msbranco/goconfig". As the >> implementations differ at the API level, the code is updated >> accordingly. > > It's great that you fixed this, but the whole idea of something failing > to build depending on the status of a website makes me pretty > uncomfortable. Me too, but this is the status quo (atm(*)). The patch looks good and state of things tolerable to me. (*) and probably things won't change in (near) future ;/ > d Tomi