Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 17967431FBF for ; Fri, 3 Oct 2014 03:50:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LUNY5z2Ahrag for ; Fri, 3 Oct 2014 03:50:16 -0700 (PDT) Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B9B93431FB6 for ; Fri, 3 Oct 2014 03:50:16 -0700 (PDT) Received: by mail-ob0-f178.google.com with SMTP id wn1so626389obc.23 for ; Fri, 03 Oct 2014 03:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=bauFOvhREnuKCWl3CKVg7PQCoWQzqOZYAp0+vCK+nyM=; b=wdOju2nQWjhaakRHIGoF9YXwYICFrodH7dihIVQkaWTgo/BC8yAjzCbqrDd4XIbc+4 dQgXzSjmi3Z8O/5k1AYeC0QtH2Pl5LSuuhWeZ4SmxuINdIc2ntSB79q5h95SqxSW5P5r YpnmCuuAY1duBJ2rI2rb17d3qEkZ6Xt+s3fMeaKuOxpeutgFsmO36RbxLvLnW2n7vL7b VZ4irl5IZ5lui9hJyvs1vxhHkdP58BBb0RbNULZEdsn+MZRxL+f77SsrPXJXYDM72Wsi E0NMUO5RRgaVQQ5YI/BUyIa24gVDaUcuWflD7mymZ7LaO1aiUDBELE8fpcZFyLHlAlo/ +pIg== MIME-Version: 1.0 X-Received: by 10.60.144.41 with SMTP id sj9mr5841004oeb.20.1412333412991; Fri, 03 Oct 2014 03:50:12 -0700 (PDT) Received: by 10.76.41.3 with HTTP; Fri, 3 Oct 2014 03:50:12 -0700 (PDT) In-Reply-To: <87r3ypr6cm.fsf@maritornes.cs.unb.ca> References: <1412286796-27479-1-git-send-email-imain@stemwinder.org> <1412293635-31273-1-git-send-email-imain@stemwinder.org> <87r3ypr6cm.fsf@maritornes.cs.unb.ca> Date: Fri, 3 Oct 2014 14:50:12 +0400 Message-ID: Subject: Re: [PATCH v2] VIM: Use notmuch CLI for config From: Sergei Shilovsky To: David Bremner Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: sshilovsky@gmail.com List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Oct 2014 10:50:20 -0000 The patch works fine for me. Ian, though I could not test whether result=3D'' matters or not, cause 'notmuch get' looks to always return a string. It also fixes id:CAHc2pO19AZabAiJhdfQR1rL5t0GufLAq5cKb_7w-Z8y+JXT5+g@mail.g= mail.com On Fri, Oct 3, 2014 at 10:54 AM, David Bremner wrote: > Ian Main writes: > >> This patch switches from reading .notmuch-config directly to using >> the CLI the same way that emacs does it. It actually uses less code >> and is probably less error prone. >> >> Ian > > The general approach seems sane; it seems quite brittle to read the > config file directly. I notice there is not really any error handling; > OTOH, as far as I can read Ruby, there is not any in the previous > version either. Technically, this does add a dependency of the vim > client on the CLI that did not exist before. Personally I don't find > this onerous (even notmuch-vim users need "notmuch new", except in > rather unusual circumstances.). > > I'd like feedback/testing from actual vim interface users before > merging. > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch --=20 =D0=A1 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC, =D0=A1=D0=B5=D1=80=D0=B3=D0=B5=D0=B9 =D0=A8=D0=B8=D0=BB=D0=BE=D0=B2=D1=81= =D0=BA=D0=B8=D0=B9 Sergei Shilovsky