Return-Path: <jani@nikula.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 12A04431FBF
	for <notmuch@notmuchmail.org>; Mon, 17 Mar 2014 12:12:40 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id LTbycXsOVQgg for <notmuch@notmuchmail.org>;
	Mon, 17 Mar 2014 12:12:32 -0700 (PDT)
Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com
 [74.125.83.54])	(using TLSv1 with cipher RC4-SHA (128/128 bits))	(No client
 certificate requested)	by olra.theworths.org (Postfix) with ESMTPS id
 525DC431FBD	for <notmuch@notmuchmail.org>; Mon, 17 Mar 2014 12:12:32 -0700
 (PDT)
Received: by mail-ee0-f54.google.com with SMTP id d49so4505175eek.13
	for <notmuch@notmuchmail.org>; Mon, 17 Mar 2014 12:12:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:from:to:subject:in-reply-to:references
	:user-agent:date:message-id:mime-version:content-type;
	bh=jpGqplDgPl7limnPoAbmUcUogO5uMetjcO4bjBW+Ols=;
	b=h8U5A4j0IO04MJRNXATBnte5++qEGfcpkENw6f9wCLGmTXXybszkez+J85shdAMqg6
	u8cRPWf6FhqiVflv7ngvWva9cEpeEdOrmL559nlhzDh3HDkC17LVN8DtSHlfVS+fI6y4
	omJarL/zWtxxxHnYTWAz0ESLBt1qZ/WF0TSu0tKMqNN1cnr8MF5zlI98aRQrJxvAR6ls
	sq9lr4DYC/4ElykwLRjvqpX7MTgelloOCq2iIV0ke8Sd1cTLqUgdb+pyHwV6gwyWpmDK
	E2kq4n09t7Bct5l+UjH2rrXbYosU/aMf37t8QbefQi3ybVzKL6WZEs+8dLBt87PyC1wG
	C2CQ==
X-Gm-Message-State:
 ALoCoQlROT7nsxxyHAHRFFl0u0XELyQgTuqlpzFZbP7+JZVg8+ON3zcy62qlxHhn5CmQsn+lcm9v
X-Received: by 10.14.106.193 with SMTP id m41mr9724281eeg.62.1395083549553;
	Mon, 17 Mar 2014 12:12:29 -0700 (PDT)
Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.
	[88.195.111.91])
	by mx.google.com with ESMTPSA id g3sm29133167eet.35.2014.03.17.12.12.27
	for <multiple recipients>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Mon, 17 Mar 2014 12:12:28 -0700 (PDT)
From: Jani Nikula <jani@nikula.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	David Bremner <david@tethera.net>, Notmuch list <notmuch@notmuchmail.org>
Subject: Re: WARNING: database upgrade coming
In-Reply-To: <87txawkam3.fsf@servo.finestructure.net>
References: <874n37a017.fsf@zancas.localnet>
	<87txawkam3.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.17+142~g30045abd801f (http://notmuchmail.org)
	Emacs/24.3.1 (x86_64-pc-linux-gnu)
Date: Mon, 17 Mar 2014 21:12:26 +0200
Message-ID: <87a9cood0l.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Mar 2014 19:12:40 -0000


Hi Jamie -

On Mon, 17 Mar 2014, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Hey, David et. al.  I recently did an upgrade to notmuch/master after
> being out of the loop for a while and not noticing that a database
> upgrade was pending.  The next notmuch new informed me that a database
> upgrade was required, but it went ahead and did the upgrade unprompted.
> Things went fine, but it did worry me a bit that I didn't know an
> upgrade was pending and didn't have a chance to do a backup before it
> happened.

FWIW it should always be safe to interrupt the upgrade; I know we don't
inform the user about this.

> It would be nice if notmuch new would prompt users when an database
> upgrade is pending, to give the user an option to abort before
> proceeding so that they can do a backup if they'd like.

Please see id:87lhy4f6pr.fsf@nikula.org for a summary on some of the
pros and cons that have been discussed about prompting the user.


BR,
Jani.