From: Pieter Praet <pieter@praet.org>
To: Jani Nikula <jani@nikula.org>, David Bremner <david@tethera.net>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] add `tag:' prefix to `--output=tags' results
In-Reply-To: <87k474cdo4.fsf@nikula.org>
References: <877hbiep5g.fsf@SSpaeth.de>
	<1309422029-22924-1-git-send-email-pieter@praet.org>
	<87k475mktx.fsf@rocinante.cs.unb.ca> <87k474cdo4.fsf@nikula.org>
User-Agent: Notmuch/0.9+76~g2fd88e6 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 16 Nov 2011 12:07:22 +0100
Message-ID: <87hb24fhqt.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Sun, 13 Nov 2011 16:14:35 +0200, Jani Nikula <jani@nikula.org> wrote:
> On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner <david@tethera.net> wrote:
> > On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet <pieter@praet.org> wrote:
> > > Alter `do_search_tags()' to prepend each result with `tag:',
> > > and update affected test.
> > > 
> > > This makes its output consistent with `do_search_threads()' and
> > > `do_search_messages()'.
> > 
> > What do people think about this change? Personally I will have change
> > some scripts to not add "tag:", but it isn't that big of a deal.
> 
> I'm curious why this change is needed in the first place. What is gained
> from this in addition to consistency? It seems I don't have enough list
> history to find the referenced discussion.
> 

Here's the original thread:
  http://comments.gmane.org/gmane.mail.notmuch.general/3562

> The command line interface is an API, and this change causes regressions
> in all scripts and programs using it, including the emacs ui. [...]

Indeed.  There's something to be said for consistency, but a change like
this is likely to cause more problems than it will solve.

> [...] (And that
> should probably be fixed with something other than "...a quick'n'dirty
> patch, thus probably not fit for consumption.")
> 

Couldn't agree more.  I wrongly assumed that the test suite would
sufficiently cover such fundamental functionality, and upon realizing
that it didn't, I quickly submitted some half-baked fixes for the most
glaringly obvious breakage, right before abandoning the whole deal.

> BR,
> Jani.


Peace

-- 
Pieter