Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E15996DE13EF for ; Tue, 8 Dec 2015 04:44:19 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.318 X-Spam-Level: X-Spam-Status: No, score=-0.318 tagged_above=-999 required=5 tests=[AWL=0.233, RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CJZyhYnrDSeY for ; Tue, 8 Dec 2015 04:44:16 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id EF7716DE1378 for ; Tue, 8 Dec 2015 04:44:15 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.84) (envelope-from ) id 1a6Hcn-0007Ws-1U; Tue, 08 Dec 2015 07:44:09 -0500 Received: (nullmailer pid 14943 invoked by uid 1000); Tue, 08 Dec 2015 12:44:10 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Cc: tomi.ollila@iki.fi Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro In-Reply-To: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi> References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi> User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 08 Dec 2015 08:44:10 -0400 Message-ID: <87egexyusl.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 12:44:20 -0000 Tomi Ollila writes: > Some compilers (older than gcc 4.5 and clang 2.9) do support > __attribute__ ((deprecated)) but not > __attribute__ ((deprecated("message"))). > > Check (clang) and know (gcc) which versions support which variants > and make two definitions of define NOTMUCH_DEPRECATED macro; > one with and and one without the ("message") part. > > __has_extension() replacement was modeled after __has_attribute() > definition in compat/function-attributes.h. Thanks Justus. Hi Tomi; I keep coming back to review this patch, but I'm blocked by the fact that clang++ is broken on Debian (and lots of other places, I guess) for months. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797038 d