Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 9CFB8429E40
	for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 05:35:57 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id wXKQciBocMht for <notmuch@notmuchmail.org>;
	Sun,  2 Jun 2013 05:35:49 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 84071429E25
	for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 05:35:49 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 4F934100030;
	Sun,  2 Jun 2013 15:35:46 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags
	instead of unread
In-Reply-To: <1370123352-13806-1-git-send-email-markwalters1009@gmail.com>
References: <1370123352-13806-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.15.2+115~g12cf6af (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 02 Jun 2013 15:35:45 +0300
Message-ID: <m2k3mcofku.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Jun 2013 12:35:57 -0000

On Sun, Jun 02 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Previously pick removed the unread tag from its tag display: since the
> tag change is now customisable use the customised variable.
>
> This only affected the tags displayed, not the tags in the database as
> notmuch-show (in the view pane) did the actual tag changes.
> ---
>
> Thanks to Tomi for pointing this out in
> id:m2r4mecofa.fsf@guru.guru-group.fi

LGTM :D

Tomi

>
> Best wishes
>
> Mark
>
>  contrib/notmuch-pick/notmuch-pick.el |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 128fabf..9079acf 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -384,7 +384,8 @@ Does NOT change the database."
>  	(with-current-buffer buffer
>  	  (setq notmuch-pick-message-window window)
>  	  (add-hook 'kill-buffer-hook 'notmuch-pick-message-window-kill-hook)))
> -      (notmuch-pick-tag-update-display (list "-unread"))
> +      (when notmuch-show-mark-read-tags
> +	(notmuch-pick-tag-update-display notmuch-show-mark-read-tags))
>        (setq notmuch-pick-message-buffer buffer))))
>  
>  (defun notmuch-pick-show-message-out ()
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch