MIME-Version: 1.0
Sender: awg@xvx.ca
In-Reply-To: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>
References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>
Date: Wed, 18 Apr 2012 11:36:36 -0600
Message-ID:
 <CAMoJFUsnpaoug58RUS_oQB9m1mhNjmBVZG5v6EDHkVqG3wX0jg@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] composing patches
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Felipe Contreras <felipe.contreras@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

Hi Felipe,

On Wed, Apr 18, 2012 at 06:39, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> I don't know how it works in gnus, but at least on the vim mode, the outp=
ut
> generated by 'notmuch reply' is not ready to be sent, at least the Messag=
e-ID
> field is needed, and also is nice to have the User-Agent.

In the emacs interface, the Message-ID header is generated when the
message is sent, so it never shows up in the reply buffer. The
User-Agent header is created by the emacs reply code.

> Besides, in order to avoid creating a new message by hand (possibly fetch=
ing
> the info from notmuch config), it's more straightforward to have 'notmuch
> compose' command.
>
> In the future 'notmuch compose' might be used to replace 'notmuch reply' =
and
> possily add a forward option too. It might also be possible to add mail a=
liases
> when composing a message, and these aliases might be used while generatin=
g the
> 'notmuch search' output.

I can see how this functionality is useful, and I like the idea of
consolidating message creation, forwarding, and reply. However, if
this is intended to replace or share code with reply (and I think it
should), it should support all the existing reply formats: default,
json, and headers-only.

In fact, I think it might make more sense to make this work an
extension of the existing reply code rather than a rewrite.
notmuch-reply.c could become notmuch-compose.c, and provide the
compose command (with flags for creating a reply), and also the reply
command (which would just be an alias to the compose functionality).

> =A0Makefile.local =A0 =A0| =A0 =A01 +
> =A0notmuch-client.h =A0| =A0 =A03 ++
> =A0notmuch-compose.c | =A0111 +++++++++++++++++++++++++++++++++++++++++++=
++++++++++
> =A0notmuch-reply.c =A0 | =A0 17 ++++++++
> =A0notmuch.c =A0 =A0 =A0 =A0 | =A0 =A05 +++

Such a big new features should definitely have some tests.

-- Adam