From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH v2 3/6] cli: add support for replying just to the sender
	in "notmuch reply"
In-Reply-To: <87ehv9jjqy.fsf@nikula.org>
References: <cover.1326058946.git.jani@nikula.org>
	<6e37e058190d7c06519de3e67569fbee0be45461.1326058946.git.jani@nikula.org>
	<877h11eq3g.fsf@qmul.ac.uk> <87ehv9jjqy.fsf@nikula.org>
User-Agent: Notmuch/0.10.2+172~g60f099b (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Mon, 09 Jan 2012 11:13:41 +0000
Message-ID: <87zkdxf7ru.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

> 
> The reply-to-thread is a rare case anyway, regardless of reply-to-all or
> reply-to-sender, and even the current implementation does not gather all
> the recipients from all the messages. Try it out, it seems to me it does
> not quite do what you think it does.
> 
> IMHO it should use oldest-first rather than newest-first sort order, and
> I guess it should really go through the messages being replied to and
> get the recipients from all of them. It's just out of scope for this
> patch set to fix these. But if that gets fixed later, I would like the
> reply-to-sender for multiple messages follow the logic of single-reply,
> just with all the addresses put together.

I completely agree it's a rare case. Having tried the code (yours and
the original) it seems to be very strange:

In its current form it seems to be reply to people on newest message in
thread and include all the bodies with some spurious headers mixed
in. So your code is reply-to-sender applied to people on newest message
in thread, and include all the bodies with some slightly different
spurious headers mixed in.

I like your suggested solution.

Anyway it's a rare case; the current code is odd and yours is no odder
so I agree with leaving it for a later patch (if anyone cares enough!).

Best wishes

Mark