From: Jani Nikula <jani@nikula.org>
To: Aaron Ecay <aaronecay@gmail.com>, David Edmondson <dme@dme.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v3 2/4] emacs: add support for replying just to the sender
In-Reply-To: <m2d3aqdjpp.fsf@gmail.com>
References: <cover.1326224339.git.jani@nikula.org>
	<069a0cddd4e848314fb64da861b3bf5b4f053f14.1326224339.git.jani@nikula.org>
	<cun39bmodjr.fsf@hotblack-desiato.hh.sledj.net>
	<m2d3aqdjpp.fsf@gmail.com>
User-Agent: Notmuch/0.10.2+193~ga73a411 (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Thu, 12 Jan 2012 00:08:29 +0200
Message-ID: <8762gh3naa.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Wed, 11 Jan 2012 16:15:30 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> On Wed, 11 Jan 2012 08:20:56 +0000, David Edmondson <dme@dme.org> wrote:
> > On Tue, 10 Jan 2012 21:54:02 +0200, Jani Nikula <jani@nikula.org> wrote:
> > > -(defun notmuch-mua-reply (query-string &optional sender)
> > > +(defun notmuch-mua-reply (query-string &optional sender reply-all)
> > >    (let (headers
> > >  	body
> > >  	(args '("reply")))
> > >      (if notmuch-show-process-crypto
> > >  	(setq args (append args '("--decrypt"))))
> > > +    (if reply-all
> > > +	(setq args (append args '("--reply-to=3Dall")))
> > > +      (setq args (append args '("--reply-to=3Dsender"))))
> > >      (setq args (append args (list query-string)))
> >=20
> > I don't like how this ends up. How about something like:
> >=20
> > (defun notmuch-mua-reply (query-string &optional sender)
> >   (let (headers
> > 	body
> > 	(args (nconc (list "reply"
> >                            (concat "--reply-to=3D"
> >                                    (if reply-all "all" "sender")))
> > 		     (when notmuch-show-process-crypto
> > 		       (list "--decrypt"))
> > 		     (list query-string))))
>=20
> What about using =E2=80=98format=E2=80=99:
>=20
> (let (...
>       (args (format "reply --reply-to=3D%s %s %s"
>                     (if reply-all "all" "sender")
>                     (if notmuch-show-process-crypto "--decrypt" "")
>                     query-string)))
>   ...)
>=20
> It=E2=80=99s still not beautiful, but maybe it is better?

I don't think it works. The arguments to call-process need to be a list,
not a string.

BR,
Jani.