Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BA331431FB6 for ; Fri, 27 Jan 2012 21:06:53 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VffUDW4ZiHDs for ; Fri, 27 Jan 2012 21:06:53 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 29016431FAE for ; Fri, 27 Jan 2012 21:06:53 -0800 (PST) Received: by bkbzt19 with SMTP id zt19so2266191bkb.26 for ; Fri, 27 Jan 2012 21:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; bh=7xIhglDxxej5mXmgE7Qk+HdyHkEqEDAMp/2/X8+DfIA=; b=crUUKZtt1IJSV+DPzsqgdOsGUpkzJcvUZoJimCFdSlMO6PEsIhZVZ83GKaRGqzDJ4D r1Bk25JrqmFkmNvz35Zk0FGoyaO435uZ1L0e7/f+Sm5+2h857VzcjPEpQgNavPOWbnLI /207Q2vij1APOXRz21r7EHB68n7m7XEwIvmPw= Received: by 10.204.128.202 with SMTP id l10mr3480003bks.116.1327727211849; Fri, 27 Jan 2012 21:06:51 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id o26sm14580691bko.14.2012.01.27.21.06.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Jan 2012 21:06:51 -0800 (PST) From: Dmitry Kurochkin To: notmuch@notmuchmail.org Subject: [PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag' function Date: Sat, 28 Jan 2012 09:05:43 +0400 Message-Id: <1327727143-24455-1-git-send-email-dmitry.kurochkin@gmail.com> X-Mailer: git-send-email 1.7.8.3 In-Reply-To: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2012 05:06:53 -0000 The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not include whitespace characters. --- emacs/notmuch.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 9813e0a..0de6123 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -555,7 +555,7 @@ notmuch-after-tag-hook will be run." ;; Perform some validation (when (null tags) (error "No tags given")) (mapc (lambda (tag) - (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag) + (unless (string-match-p "^[-+]\\S-+$" tag) (error "Tag must be of the form `+this_tag' or `-that_tag'"))) tags) (run-hooks 'notmuch-before-tag-hook) -- 1.7.8.3