Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 15071431FD0 for ; Tue, 27 Dec 2011 08:47:21 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q9wMKyNyY-2h for ; Tue, 27 Dec 2011 08:47:20 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 30B2D431FB6 for ; Tue, 27 Dec 2011 08:47:20 -0800 (PST) Received: by werm12 with SMTP id m12so6797479wer.26 for ; Tue, 27 Dec 2011 08:47:18 -0800 (PST) Received: by 10.216.139.96 with SMTP id b74mr21514005wej.10.1325004438855; Tue, 27 Dec 2011 08:47:18 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id g26sm2347812wbo.16.2011.12.27.08.47.16 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 27 Dec 2011 08:47:17 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 9F47BA07D5; Tue, 27 Dec 2011 16:47:15 +0000 (GMT) From: David Edmondson To: notmuch@notmuchmail.org Subject: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'. Date: Tue, 27 Dec 2011 16:47:14 +0000 Message-Id: <1325004434-24583-1-git-send-email-dme@dme.org> X-Mailer: git-send-email 1.7.7.3 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Dec 2011 16:47:21 -0000 The tags were coloured using text properties. Unfortunately that text (the header line) also has an overlay, which overrides the text properties. There's not point in applying text properties that will never be seen. --- emacs/notmuch-show.el | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 8c9d846..24f0b40 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -221,10 +221,7 @@ indentation." (goto-char (notmuch-show-message-top)) (if (re-search-forward "(\\([^()]*\\))$" (line-end-position) t) (let ((inhibit-read-only t)) - (replace-match (concat "(" - (propertize (mapconcat 'identity tags " ") - 'face 'notmuch-tag-face) - ")")))))) + (replace-match (concat "(" (mapconcat 'identity tags " ") ")")))))) (defun notmuch-show-clean-address (address) "Try to clean a single email ADDRESS for display. Return @@ -278,8 +275,7 @@ message at DEPTH in the current thread." " (" date ") (" - (propertize (mapconcat 'identity tags " ") - 'face 'notmuch-tag-face) + (mapconcat 'identity tags " ") ")\n") (overlay-put (make-overlay start (point)) 'face 'notmuch-message-summary-face))) -- 1.7.7.3