From: Michal Sojka <sojkam1@fel.cvut.cz>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Do not color non-matching authors by tag
In-Reply-To: <87zktp2lma.fsf@ut.hh.sledj.net>
References: <1287726122-5643-1-git-send-email-sojkam1@fel.cvut.cz>
	<878w1942i6.fsf@ut.hh.sledj.net> <87vd4djhy2.fsf@steelpick.2x.cz>
	<87zktp2lma.fsf@ut.hh.sledj.net>
User-Agent: Notmuch/0.4-29-g9b64b0f (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Fri, 05 Nov 2010 09:10:00 +0100
Message-ID: <87mxpojinb.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 04 Nov 2010, David Edmondson wrote:
> On Thu, 04 Nov 2010 15:12:53 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > > Michal, was this addressed by the patch that Carl recently merged?
> > > (Commit f99ad42da03afd638bfdfdea92d1cbdd3b510b8f in my copy of the
> > > repository.)
> > 
> > Unfortunately not. In your patch, the overlay changes the color/face of the
> > whole line while my patch change the color/face of all parts of the line
> > except for non-matching authors. With my patch non-matched autors were
> 
> I understand now.

> 
> This seems somewhat like a policy decision, though. If I indicate that I
> want the foreground text for a particular line to be red, should the
> formatting of non-matching authors override that?
> 
> (My own approach has been to have `notmuch-search-line-faces' always
> specify a background colour whereas
> `notmuch-search-non-matching-authors' (or any of the columnar faces)
> specify a foreground colour and/or slant.)

And now I even understand your patch. That's exactly what I wanted.
Nice. I thought that overlays change completely the face of the line,
hiding any faces "under" the overlay. Now I see, that
notmuch-search-line-faces faces are combined with what was there before.

-Michal