Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BA21E431FBC; Fri, 27 Nov 2009 05:46:46 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W1j9kqE-XsRK; Fri, 27 Nov 2009 05:46:46 -0800 (PST) Received: from cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1F647431FAE; Fri, 27 Nov 2009 05:46:46 -0800 (PST) From: Carl Worth To: Chris Wilson , notmuch@notmuchmail.org In-Reply-To: <1259091680-29598-1-git-send-email-chris@chris-wilson.co.uk> References: <1259091680-29598-1-git-send-email-chris@chris-wilson.co.uk> Date: Fri, 27 Nov 2009 05:46:32 -0800 Message-ID: <878wdsqdvr.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [notmuch] [PATCH] notmuch-new: Remove the tiresome joke from the output. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 13:46:46 -0000 On Tue, 24 Nov 2009 19:41:20 +0000, Chris Wilson wrote: > As I see this every time I poll for new mail, the joke becomes very old > very quickly. The other instances of "not much" are shown much less > often and have a much more natural style, this one however feels forced, > impairing the humorous effect. Fine. My joke wen stale quickly. I'll agree to remove it. > - } else { > - printf ("No new mail---and that's not much.\n"); > } Shouldn't we still print *something* here, though ("No new mail")? Imagine the new user trying to ensure "notmuch new" is working---and let's say it's not, (due to the current symlink bug or so). A silent success here won't make it clear whether "notmuch new" has actually done anything or not. -Carl