Sender: Michal Nazarewicz <mpn@google.com>
From: Michal Nazarewicz <mina86@mina86.com>
To: Taesoo Kim <taesoo@mit.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] Automatic tagging based on maildir
In-Reply-To: <1351208039-32293-2-git-send-email-taesoo@mit.edu>
Organization: http://mina86.com/
References: <1351208039-32293-1-git-send-email-taesoo@mit.edu>
	<1351208039-32293-2-git-send-email-taesoo@mit.edu>
User-Agent: Notmuch/0.14+22~g8bdc16b (http://notmuchmail.org) Emacs/24.2.50.1
	(x86_64-unknown-linux-gnu)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC
Date: Fri, 26 Oct 2012 15:19:54 +0200
Message-ID: <xa1tr4olpdz9.fsf@mina86.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Cc: Taesoo Kim <taesoo@mit.edu>
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 26 2012, Taesoo Kim <taesoo@mit.edu> wrote:
> @@ -240,6 +242,32 @@ _entry_in_ignore_list (const char *entry, add_files_=
state_t *state)
>      return FALSE;
>  }
>=20=20
> +static void
> +_add_maildir_as_tag(notmuch_database_t *notmuch,
> +		    notmuch_message_t *msg, const char *path)=20
> +{
> +    char *tok =3D talloc_strdup (notmuch, path);
> +    int len =3D strlen(tok);
> +=20=20=20=20
> +    /* asserts path ends with /cur|/tmp|/new */

It actually does not assert that.  It just checks =E2=80=9C/=E2=80=9D.

> +    if (len > 4 && tok[len - 4] =3D=3D '/') {
> +	char *iter =3D tok + len - 4;
> +	*iter =3D '\0';
> +	while (-- iter && iter >=3D tok) {
> +	    char c =3D *iter;
> +	    if (c =3D=3D '/' || c =3D=3D '.') {
> +		*iter =3D '\0';
> +		notmuch_message_add_tag (msg, iter + 1);
> +		if (c =3D=3D '/') {
> +		    break;
> +		}
> +	    }
> +	    *iter =3D tolower(*iter);
> +	}

strtok() would make it easier.

> +    }
> +    talloc_free (tok);
> +}

How about (not tested):

static void
_add_maildir_as_tag(notmuch_database_t *notmuch,
		    notmuch_message_t *msg, const char *path)
{
    const char *a =3D NULL, *b =3D NULL;
    char *dir, *tag, *saveptr;

    while ((path =3D strchr(path, '/'))) {
	a =3D b;
	b =3D path;
    }

    if (!a || ++a >=3D b ||
	(strcmp(b, "/cur") && strcmp(b, "/new") && strcmp(b, "/tmp")))
	return;

    dir =3D talloc_strndup(notmuch, a, b - a);
    while ((tag =3D strtok_r(dir, ".", &saveptr)))
	notmuch_message_add_tag(msg, tag);

    talloc_free(dir);
}

--=20
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =
 (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/plain


--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBAgAGBQJQio36AAoJECBgQBJQdR/0E+8P/1nGvBlGhqQpcbqen2TBT0AI
kkg9qZua/QI+l9DcpFAP3P979Ux+2QgJagIuiC5QE68pJ9zyYUft8WVau252ycl+
pEMhk4y8cT2ttsJJzSEWA2kd1+Bknkn0/jdWSgKd3hoJ47XIEF8MpeJZ5QY0W+eG
pjcqCKk5So118v7UAMSkhX5UOzT7IvUYcHuPKns8eaGv9D0TcmYPJRCvQdWoyXUB
auo8ktTe8MqL1ZdKMFmKcGvI257J8F5bccHLUFSKKw+oO6RzCR5Sb+v4ejmwKlPs
o5UIyaSJFHTOndTdxAyw8C1bE2dy+ryStN1gFpu92/f68j/Qr2NYnRbMVUOqTMVt
+1T35voXdmGvhzQAAAqBipgzSDNGZMMnBy4fl9sBFGIrE3ZjzixXe5XXcrVTWnhd
V6gwHOZ+KDP/CYQEOySrftIs3TxDGZq7p7ViHRpfq0FJ/v7/sEhSUv4P76O0xvJi
k+kvNGpOcbp64IhhoCKS3EqLRqJ990iuzrNKGx6eSesgjxRVoUvwRt/bcU+/StY/
x0rZRRe6rlZ2v1+OIx1FtSOc6mGNzlyVeAHsE44/hKayxmt6cQ1I0u8FeCO8G4ok
LMbHyknpnp9NdTIG1E5x2cX0nUnZ38Sh+zckBbZjbjGAXi9Qna35W3iETLoBh8ch
C5SwGi23JNMnRQw0qCjz
=ug1A
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--