From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@mit.edu>
Subject: [PATCH] smtp-dummy: clear sockaddr_in structure before use in bind()
In-Reply-To: <20111112024004.GX2658@mit.edu>
References: <yf6k477a70b.fsf@taco2.nixu.fi> <20111112024004.GX2658@mit.edu>
User-Agent: Notmuch/0.9+23~g556c5fa (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Sat, 12 Nov 2011 11:57:22 +0200
Message-ID: <yf68vnlll31.fsf@taco2.nixu.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

Any junk bytes in sockaddr_in structure before passing that
to bind() system call may cause problems.
---

Thanks Austin. Consistent style matters... And dropped the peer_addr
setting after reading accept(2) namual page.

 test/smtp-dummy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c
index 9da8202..1778a45 100644
--- a/test/smtp-dummy.c
+++ b/test/smtp-dummy.c
@@ -159,6 +159,7 @@ main (int argc, char *argv[])
 		return 1;
 	}
 
+	memset (&addr, 0, sizeof (addr));
 	addr.sin_family = AF_INET;
 	addr.sin_port = htons (25025);
 	addr.sin_addr = *(struct in_addr *) hostinfo->h_addr;
-- 
1.5.6.5