From: Jameson Rollins <jrollins@finestructure.net>
To: Carl Worth <cworth@cworth.org>, Sebastian Spaeth <Sebastian@SSpaeth.de>,
	Notmuch Mail list <notmuch@notmuchmail.org>
In-Reply-To: <87vddmwkuw.fsf@yoom.home.cworth.org>
References: <87ska1vh7r.fsf@servo.finestructure.net>
	<87ljes0yy0.fsf@SSpaeth.de> <87vddmwkuw.fsf@yoom.home.cworth.org>
Date: Wed, 24 Feb 2010 14:20:27 -0500
Message-ID: <87r5oa1lvo.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Subject: Re: [notmuch] [PATCH] Simplify "unread" tag handling in emacs UI.
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 24 Feb 2010 10:26:47 -0800, Carl Worth <cworth@cworth.org> wrote:
> On Wed, 17 Feb 2010 14:33:11 +0100, "Sebastian Spaeth" <Sebastian@SSpaeth=
.de> wrote:
> > On Tue, 19 Jan 2010 17:54:16 -0500, Jameson Rollins <jrollins@finestruc=
ture.net> wrote:
> > > This patch is intended to greatly simplify the handling of the
> > > "unread" tag in the emacs UI.  This patch adds a new function
> > > 'notmuch-show-mark-read', that removes the "unread" tag in
> > > notmuch-show-mode.  This function is then executed as a
> > > notmuch-show-hook, and by notmuch-show-next-message.  All of the
> > > functions that explicitly marked messages as unread are removed or
> > > renamed.

> Thanks for contributing the patch. This exact feature, (removing all
> commands with "and mark read" in their names), has been on my todo list
> for too long, and I'm anxious to remove it from that. But...
>
> > It then checks the unread status in order to decide whether to proceed
> > to the next again. So with your patch notmuch-show-next-unread-message
> > will skip through all messages in a thread thinking they are all read
> > (and actually marking all as read).
>=20
> ...that seems like a fatal bug in this script. Thanks for noting that
> Sebastian.

I certainly don't see it as fatal, but it is something we should
resolve.  I think the simplification that the patch provides is worth
it.

I'm seeing the notmuch-show-next-unread-message as a non-interactive
function that's not currently called by any other functions, and is
therefore not being used.  Sebastian, are you using that in a private
function, or am I misreading the code?

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJLhXv7AAoJEO00zqvie6q8etkQAIeR17fLFhIYfkCAxP7OasPY
e3WK+wNNH5BnVF3OgmavBz6wl+Nwt8406RNDAgqS0c9SFQlXhLpVCXRJESUeRSsA
fG+WmIqsC8EG/Gh7ApAnxiXL1IZ8wSvEfrQYCLudjqUwmCNthEHRyCEr5l5qcbCf
ZWiE8XB74vvPLg+C5hUp074Vr7B3gYEDZXv3d8T7Et8DsqgIbjX95taxskSj4l69
G1IRUVg29laTNGBKYu6xoYVpnfkzSmJHC70rIgGR/Vh4YSIRhHnTbamKB63ficrS
IhcPTmse44JFrAqGASiw1ldbsjnq9V0Hy9HDZ8iyc4R+quJHXDxYwmOIQbvqBFnh
Q2rTNoLwS/mBjGLJNmiJx3nvt383g5q9eFEbEFeIQ3Xa2ZWXEAcf6ttbITjociQQ
8WyWDUmfpZ+ztwdJhEpW3iCyOjGucjMm+hhiS+EJdiSWfnTR6ZdSXISP2AUiW8cH
xdg9pIYR34hSTInDY1mr54R5o4aIB+A4Pr9adZ8OwitiVp1foEAQxpFGgrvFtUp6
JZkT7fMsiV+YxxvQR0ObHTadbyScc8Tb4IRkXbQhOzsG6iFoyopZXvVXMMb0rdC3
iPz2xhThliLqRrqf6nJWFKNKdRvVHuXqLMr2fF3IiD8NxMbwjriaqxXySRDRfuKl
r93KAJk6hQjm46APgGNG
=Y0ut
-----END PGP SIGNATURE-----
--=-=-=--