Date: Sat, 8 Feb 2014 09:33:33 -0800
From: "W. Trevor King" <wking@tremily.us>
To: Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for
	part buttons
Message-ID: <20140208173333.GC17142@odin.tremily.us>
References: <877g9chbay.fsf@qmul.ac.uk>
 <cover.1391423201.git.wking@tremily.us>
	<27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us>
	<87vbwwosuw.fsf@qmul.ac.uk>	<20140203203418.GO14197@odin.tremily.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Izn7cH1Com+I3R9J"
Content-Disposition: inline
In-Reply-To: <20140203203418.GO14197@odin.tremily.us>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: notmuch@notmuchmail.org
Precedence: list


--Izn7cH1Com+I3R9J
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 03, 2014 at 12:34:18PM -0800, W. Trevor King wrote:
> On Mon, Feb 03, 2014 at 08:15:35PM +0000, Mark Walters wrote:
> > My only other comment on the series is that you should update
> > devel/schemata in the first patch to reflect this addition.
>=20
> Ah, I didn't realize that file existed :p.

Looking at this more, I'm unsure about whether or not I should bump
the version.  b96ba63 (show: indicate length, encoding of omitted body
content, 2012-12-16) added part.content-length? and
part.content-transfer-encoding? and doesn't bump the version, while
abeac48 (search: Add stable queries to thread search results,
2013-10-24) adds thread_summary.query and does bump the version.  From
notmuch-client.h:

 Backwards-incompatible changes such as removing map fields, changing
 the meaning of map fields, or changing the meanings of list elements
 should increase this.  New (required) map fields can be added without
 increasing this.

I think that the addition of part.content-description? should not bump
the version, but then I'm not sure how to document the change in
devel/schemata.  I'm leaning towards something like:

  diff --git a/devel/schemata b/devel/schemata
  index 41dc4a6..63d8aa4 100644
  --- a/devel/schemata
  +++ b/devel/schemata
  @@ -26,6 +26,9 @@ v1
   v2
   - Added the thread_summary.query field.

  +Staged for v3
  +- Added the part.content-descrition? field.
  +
   Common non-terminals
   --------------------
  =E2=80=A6

Alternatively, there could be a minor version that gets bumped on each
tweak, however insignificant.

Thoughts?

Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--Izn7cH1Com+I3R9J
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJS9mprAAoJEKKfehoaNkbtr7UP/iNtM8JLTfjxmldBtMXiaaIr
pDQCggBf0fv4e/JtIpqbDqENapog/vZCDm8QxBLCxjMOVIVauanUqqw8g9U5DUvX
5y4glW9iG1fpBFFmfjy/2etxbs9W5SyEVbpMlXPbtQxPdWjtheJSoPfktbknuBT2
iUXWkZHsWL4o1hn+MtJ09EhcUWOFr/o2YtH7oLznsuZshsDFHOqWLHnB7vbNI8P2
zFP0iDBDCnVuRLKuC/7aWk82lzVMoD2FI9Hr4Mp3ryIR9/ByR+4+1CjpNGzJ/Lxa
nN83cQrAFG024Y7OklRX+G/mDeUjIHBXrSj2Rw9QtQFhJPc8cPNMSBqZn1nIfbKK
s3czIqwhRdU9fbVmG+TtjLAiT6Km+dkQztpV/sdscRqzU+zjkwIwF6Y8giS4t1mQ
3Srt9vHMg9AoaLPrydbg9R9pN5ROsO3NwINcxpyz7wGQebbtWbpKrIeHTZMoF62K
sdIZONARnVHD00JaFNuLb8VmtaifnSsq2gUhtJeADNIiarNKrcWfUa0WxOxU2u2Z
gYczozP4sZBIsvQdNyCmCyrbaIw9XD59RFbksFqaoQKOxe+qDphr4H29xzPuklMO
UdiDvFD9Vp9iQ1Db0TjmLOVrJFGLOJm+D/fwIfCCgWSDDEAQeZIhspZXgP2Xrz5u
497VrnvdUXMVWrn6d0qn
=zORU
-----END PGP SIGNATURE-----

--Izn7cH1Com+I3R9J--