From: Thomas Jost <schnouki@schnouki.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6
In-Reply-To: <yf6lip65wbh.fsf@taco2.nixu.fi>
References: <8739bea9lc.fsf@thor.loria.fr>
	<1326797453-9405-1-git-send-email-schnouki@schnouki.net>
	<1326797453-9405-2-git-send-email-schnouki@schnouki.net>
	<yf6lip65wbh.fsf@taco2.nixu.fi>
User-Agent: Notmuch/0.11+81~g9729eac (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-unknown-linux-gnu)
Date: Tue, 17 Jan 2012 14:23:07 +0100
Message-ID: <87y5t68nus.fsf@thor.loria.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 17 Jan 2012 14:48:34 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost <schnouki@schnouki.net> w=
rote:
> > There are lots of API changes in gmime 2.6 crypto handling. By adding
> > preprocessor directives, it is however possible to add gmime 2.6 compat=
ibility
> > while preserving compatibility with gmime 2.4 too.
> >=20
> > This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info".
> >=20
> > This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31,=
 the
> > crypto tests all work fine (as expected). With gmime 2.6.4, one crypto =
test
> > fails (signature verification with signer key unavailable) but this wil=
l be hard
> > to fix since the new API does not report the reason why a signature ver=
ification
> > fails (other than the human-readable error message).
> > ---
>=20
> LGTM. Some whitespace things but most of those were there already;
> I'd have one uncrustify round to be applied to the source and after
> that be more strict about those...

Thanks! I'll fix the whitespace issues in these patches when the source
in Git is uncrustified then.

> actually gmime 2.4 has GMIME_CHECK_VERSION defined as
> g_mime_check_version (major, minor, micro) so the comment about it
> is not entirely accurate (it is unusable in our context, though)

Oops, yes. What I really meant is that GMIME_MAJOR_VERSION is not
available as a preprocessor constant in 2.4, and GMIME_CHECK_VERSION is
unusable in our context since it just calls a runtime function.

By the way, how do you guys feel about setting GMIME_26 in
notmuch-client.h? Is that good enough, or should it be done in configure
so that gcc is called with "-DGMIME_26"?

I filed a bug about gmime 2.6 incorrect handling of signatures with
missing public keys: https://bugzilla.gnome.org/show_bug.cgi?id=3D668085.
A patch is attached there, feel free to test and comment.

(Arch Linux users: I made a little PKGBUILD that includes this patch if
you want to build your own gmime 2.6.4:
http://fichiers.schnouki.net/tmp/gmime-2.6.4-1.src.tar.gz)

Best regards,

=2D-=20
Thomas/Schnouki

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJPFXY7AAoJEMPdciX+bh5I2FUH/0eH0QTlJn9ytAXxKBtGu16N
SUe9BpM5BbEKe/o7AaCyvECeTIrTo+6EGDYfuTOslamWS9T7M3mO2y75rcdzOMxL
Ae5Du9rTfBGLPgl/RQyLVwyfUt3iaw9kMrVXG1Ed3mQ8bEtwk/nrt7RYH/dm4Yfn
qw3N2KDAcemJN40c99U6KpGJN4G5huuf6UL+HfA+7lipGm4e2FP76BGHWMKWG2Ty
1S8l4AWowpInfrudTx1k1u7SeNVgFjZ+9Md4FR2uiA7tJKAziwWqi5LUZ7On0fXa
z7ZbpLoPrSCwxPyZtGIgazbLHMcNAMwTaNIoeHXnIwHwH/cl62uVRVFHLrVZ9hs=
=E7Zy
-----END PGP SIGNATURE-----
--=-=-=--