From: Jameson Rollins <jrollins@finestructure.net>
To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] emacs: send notmuch-query stderr to /dev/null
In-Reply-To: <87lj27ymqg.fsf@yoom.home.cworth.org>
References: <878vy7tjog.fsf@servo.finestructure.net>
	<87lj27ymqg.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5-96-g01f9ea1 (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Thu, 27 Jan 2011 16:04:51 -0800
Message-ID: <87oc7199lo.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Thu, 27 Jan 2011 14:49:43 +1000, Carl Worth <cworth@cworth.org> wrote:
> On Wed, 26 Jan 2011 12:57:50 -0800, Jameson Rollins <jrollins@finestructu=
re.net> wrote:
> > The call-process to notmuch in notmuch-query.el was previously sending
> > stderr into the output buffer.  This means that if there is any stderr
> > the JSON parsing breaks.  Unfortunately call-process does not support
> > sending stderr to a separate buffer or to the minibuffer [0], but it
> > does support sending it to /dev/null.  So we do that here instead.
> >=20
> > [0] a bug was filed against emacs (#7842)
>=20
> Thanks! I had wondered what those json errors were about. I've committed
> this.
>=20
> I am a bit concerned about throwing the error output away, of course,
> (so we'll wait for that fix to emacs---thanks for submitting a bug
> report). Do you have a sense of what kinds of output we are getting on
> stderr?

So the only stderr output I've ever seen seen is in the
signature-verification branch (which I now run).  Emails with S/MIME
signatures are currently not handled (because of GMIME limitations, I
think) and notmuch throws the following error when trying to process
them:

servo:~ 0$ notmuch show --format=3Djson --verify id:"4D25D062.1000103@sixde=
monbag.org" >/dev/null
Failed to verify signed part: no error explanation given
servo:~ 0$=20

Obviously the emacs call-process function should be capturing and
displaying those error messages.  Hopefully we can eventually get that
fixed.  In the mean time it's probably better to throw out the messages
rather than have them break the JSON output.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJNQggjAAoJEO00zqvie6q8pU8QAJA8jml3vJjDgtC5PFzydC+0
TehFfFZipdlm5V9RAUTvcem9RRq16DPlDL/NA6Qj3KI+9ajcAzW0MQQbVnxepS1S
gP0yQNnPqzynQaSyJs2DAAVfyjlrbpumGTXBmkgbEuLF1OleyblaiyWxH1YhQvZR
kRBOPCJBnXJl2c0x6EETmdLl1KoHQ34+ENmfeM8Whp6L2zmL/ePVRqHmW9Av6bo8
8sOOVMd/rmRz1uJJpL1oaqQ0c4LyN8Mhlbsh3EWelzh2gI5HG156U2PXiOgYntqF
eZDB6iWrdzHE4Pbrfq/nB/jAYoKuB8K1r4atw4CkEtjPN1GC2a/2Lxa7PqFmPmen
ifZJNLz21Knq/IvmMJkx167qY/b/2WTWIz/uuyG0Pcws3djQHQCNhQ3NC/81z22u
4pV41SILNE2mB/cpAhLoeQc8q9iRuWtDvAjxL6r3ALvtMSZvp0ml8yDk/ySSpBjf
eBUHqopGef54rD5ALLlp3fus8cTmy86LG85hFFU0UfQ/BpvH781/T4MxL9lUwjnH
H7MYEwvImLoYM5yNPme+e6DskwqH7nExxV0FMpkbh9xdaBI5HW4q+t87ILoaB0ap
K0sdtbgqj4wfGgo3LeHEuELosMKZm6JCgSZryHJKctSaXO6t05UD9vJmHGgTfKf5
jUW8oUCHb129IAtta7OE
=XX/e
-----END PGP SIGNATURE-----
--=-=-=--