Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D7F72429E26 for ; Tue, 13 Dec 2011 13:23:44 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K9WLatrMDtB3 for ; Tue, 13 Dec 2011 13:23:42 -0800 (PST) Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5585E429E25 for ; Tue, 13 Dec 2011 13:23:42 -0800 (PST) Received: from pps.filterd (mail-gw3 [127.0.0.1]) by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBDLNVA9015875; Tue, 13 Dec 2011 23:23:31 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by mail-gw3.nixu.fi with ESMTP id 114cs0t4rv-1 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Tue, 13 Dec 2011 23:23:31 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id pBDLNVod032095; Tue, 13 Dec 2011 23:23:31 +0200 From: Tomi Ollila To: Dmitry Kurochkin , David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] test: optionally print subtest number In-Reply-To: <87pqfsur2c.fsf@gmail.com> References: <1323806207-31888-1-git-send-email-david@tethera.net> <87ty54ut1s.fsf@gmail.com> <87pqfsur2c.fsf@gmail.com> User-Agent: Notmuch/0.10.2+93~g631d290 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2011-12-13_03:2011-12-13, 2011-12-13, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1112130235 Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2011 21:23:45 -0000 On Wed, 14 Dec 2011 00:58:35 +0400, Dmitry Kurochkin wrote: > On Tue, 13 Dec 2011 22:55:18 +0200, Tomi Ollila wrote: > > On Wed, 14 Dec 2011 00:15:43 +0400, Dmitry Kurochkin wrote: > > > > > > Looks good to me. Except for tabs taking too much space. Perhaps the > > > following would be better? > > > > > > printf "%-4s" "[$(($test_count - 1))]" > > > > I attempted the same size reduction. Therefore I know that > > this should to be either > > > > printf " %-4s" "[$(($test_count - 1))]" > > or > > printf "\t%-4s" "[$(($test_count - 1))]" > > > > (or something similar) so that there is space betweem BROKEN and [num] > > > > Oh, apparently, not enough testing on my side. > > I vote for the first version with a space. Have to agree, Now that I checked tabs were not used in output lines before this addition. > > Regards, > Dmitry Tomi > > > This takes 4 bytes out from width (and drops tab as field separator) > > (and only few lines goes over 80 char width (some goes even with this > > reduction). So ... > > > > > > > Regards, > > > Dmitry > > > > Tomi