DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	b=j8VCEZNqXmv5YeNauF3WkhAyadWsxkS4YWfwFyoICMDIPf7S34SU3R08jfoOcU2+qo
	b0X0qW3bM3WgTHBO25QORXcQOAkCUa3p5zNgiCOIz5tze01DY6dh6pRHzXon+fqJBQKz
	Jae+8WTn0b0Irv2lWxga0BiOdF+CMoG56do60=
MIME-Version: 1.0
Sender: amdragon@gmail.com
In-Reply-To: <87zkms80zf.fsf@praet.org>
References: <8762pn7gth.fsf@servo.factory.finestructure.net>
	<87iptkfzwx.fsf@servo.factory.finestructure.net>
	<877h9zokod.fsf@servo.factory.finestructure.net>
	<878vuencm5.fsf@servo.factory.finestructure.net>
	<878vuejym8.fsf@servo.factory.finestructure.net>
	<87wrhw2jmm.fsf@praet.org>
	<BANLkTi=iz6F+1-WQ5KDno6N-MF=dQeTbEA@mail.gmail.com>
	<87zkms80zf.fsf@praet.org>
Date: Thu, 12 May 2011 13:52:45 -0400
Message-ID: <BANLkTikT4AK0wo8j7AP7CT0yvD57+g2HzA@mail.gmail.com>
Subject: Re: release-candidate/0.6
From: Austin Clements <amdragon@mit.edu>
To: Pieter Praet <pieter@praet.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

Nifty.  I was afraid to go romping through all of the other test
dependencies; I'm glad somebody wasn't.  ]:--8)

It should be noted that these patches depend on
id:1305206110-17511-1-git-send-email-amdragon@mit.edu for correctness
and id:1305206080-17461-1-git-send-email-amdragon@mit.edu for sanity.

Given that these patches aren't specifically 0.6-related and that it's
good practice to send patches to the list, perhaps you could git
send-email these patches as a new thread to the list?

On Thu, May 12, 2011 at 10:09 AM, Pieter Praet <pieter@praet.org> wrote:
> On Thu, 12 May 2011 09:18:48 -0400, Austin Clements <amdragon@mit.edu> wr=
ote:
>> On Thu, May 12, 2011 at 8:22 AM, Pieter Praet <pieter@praet.org> wrote:
>> > The atomicity tests were failing here because I didn't have GDB
>> > installed, so I've added it as a prereq.
>>
>> Sorry, I've had a patch to address that sitting around, but hadn't
>> sent it out (and I only fixed that one test). =A0I would suggest a
>> somewhat gentler approach than "error", though:
>>
>> if test_expect_success "prereq: gdb is present" "which gdb"; then
>> =A0 =A0 test_set_prereq GDB
>> fi
>>
>> (Plus the two test-lib patches I just sent:
>> id:1305206080-17461-1-git-send-email-amdragon@mit.edu and
>> id:1305206110-17511-1-git-send-email-amdragon@mit.edu).
>>
>> "error" has the disadvantage that it doesn't get counted as a failed
>> test in the final tally (because, indeed, it's not a failed test) and
>> also that it immediately terminates the test script so it's not
>> actually using the prereq system (which is fine for the atomicity test
>> since all of the test cases depend on GDB, but the pattern I'm
>> proposing works for finer-grained prerequisites). =A0Plus, with the
>> above approach, if you don't have a prerequisite, the final tally
>> shows one failed test plus some number of skipped tests (and the total
>> number of tests never changes), which I would argue is cleaner.
>
> Much obliged for the correction!
>
>
> Peace
>
>
> [0] git://github.com/praet/notmuch.git
> =A0 =A0for-review/test-prereqs-v2
> =A0 =A0c9a785fc5c48db13
>
> --
> Pieter
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
>