Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 598AE4196F0 for ; Mon, 26 Apr 2010 14:48:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 62hz84UqsONB; Mon, 26 Apr 2010 14:48:19 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 96966431FC1; Mon, 26 Apr 2010 14:48:19 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 41F3E55006B; Mon, 26 Apr 2010 14:48:19 -0700 (PDT) From: Carl Worth To: Dirk Hohndel , notmuch@notmuchmail.org Subject: Re: For 0.3 - cleaned up patches rebased on origin/master In-Reply-To: <1272311915-30575-1-git-send-email-hohndel@infradead.org> References: <1272311915-30575-1-git-send-email-hohndel@infradead.org> User-Agent: Notmuch/0.2-216-g4b34eff (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu) Date: Mon, 26 Apr 2010 14:48:19 -0700 Message-ID: <87pr1lx4v0.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 21:48:20 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 26 Apr 2010 12:58:33 -0700, Dirk Hohndel wr= ote: > based on your comment on IRC I have rebased this patch to the current > origin/master and split it in two parts, one that makes the Received: hea= der > special when getting headers from a message file, and one that changes the > heuristic by which we guess the best From: header. This passes the tests = that > have been committed last week. Fantastic. All pushed. The test cases give me the freedom to rework the style of these patches as I want, for example to use talloc more to avoid lots of free (temporary); return result; And I can do that with the comfort of trusting the test suite to catch any mistakes I introduce. Whether otherwise, I would be less daring to touch it and would have pushed for more style changes before merging. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFL1goj6JDdNq8qSWgRAvfMAJ45XdbAZPElzurzrV9unCWCg1wxFACfTBTS eZePLtJrzLR5pTThc0tW1yo= =rUMt -----END PGP SIGNATURE----- --=-=-=--