Return-Path: <prvs=jrosenthal=720713242@jhu.edu>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id AC69D4196F2
	for <notmuch@notmuchmail.org>; Wed, 21 Apr 2010 16:25:46 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.301
X-Spam-Level: 
X-Spam-Status: No, score=-2.301 tagged_above=-999 required=5
	tests=[BAYES_20=-0.001, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 8rRNvOZhB64X for <notmuch@notmuchmail.org>;
	Wed, 21 Apr 2010 16:25:45 -0700 (PDT)
Received: from ipex1.johnshopkins.edu (ipex1.johnshopkins.edu [162.129.8.141])
	by olra.theworths.org (Postfix) with ESMTP id 9B09D431FC1
	for <notmuch@notmuchmail.org>; Wed, 21 Apr 2010 16:25:45 -0700 (PDT)
X-IronPort-AV: E=Sophos;i="4.52,252,1270440000"; d="scan'208";a="317399153"
Received: from c-69-255-36-229.hsd1.md.comcast.net (HELO lucky)
	([69.255.36.229])
	by ipex1.johnshopkins.edu with ESMTP/TLS/AES256-SHA;
	21 Apr 2010 19:25:44 -0400
Received: from jkr by lucky with local (Exim 4.69)
	(envelope-from <jrosenthal@jhu.edu>)
	id 1O4jId-0003P4-9v; Wed, 21 Apr 2010 19:25:43 -0400
From: Jesse Rosenthal <jrosenthal@jhu.edu>
To: Dirk Hohndel <hohndel@infradead.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Add 'd'elete keybinding to search and show views
In-Reply-To: <1271891763-10757-2-git-send-email-hohndel@infradead.org>
References: <1271891763-10757-1-git-send-email-hohndel@infradead.org>
	<1271891763-10757-2-git-send-email-hohndel@infradead.org>
Date: Wed, 21 Apr 2010 19:25:43 -0400
Message-ID: <874oj48k20.fsf@jhu.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2010 23:25:46 -0000


Hi Dirk,

On Wed, 21 Apr 2010 16:16:03 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> +	     (if delete
> +		 (notmuch-show-add-tag "deleted")))

The one thing I would suggest is adding a level of customizability,
instead of hardcoding in "deleted".
i.e.:
 
  (defvar notmuch-delete-tag "deleted")

and then:

  (if delete
      (notmuch-show-add-tag notmuch-delete-tag))


The less we force specific tags on users, it seems to me, the better.

Best,
Jesse