From: Carl Worth <cworth@cworth.org>
To: Keith Packard <keithp@keithp.com>, notmuch@notmuchmail.org
In-Reply-To: <1258493565-13508-1-git-send-email-keithp@keithp.com>
References: <1258493565-13508-1-git-send-email-keithp@keithp.com>
Date: Mon, 23 Nov 2009 00:19:29 +0100
Message-ID: <87d43axi4e.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [notmuch] [PATCH] Make notmuch-show 'X' (and 'x') commands
 remove inbox (and unread) tags
Precedence: list

On Tue, 17 Nov 2009 13:32:45 -0800, Keith Packard <keithp@keithp.com> wrote:
> When closing a thread view, mark the thread as archived by removing
> the "inbox" tag, and for the 'x' variant, the "unread" tag as well,
> then kill the buffer and update the search window view as well.

I'm starting to come around to this patch, Keith. :-)

I think one thing we're going to really need is a better help message
for presenting the keybindings. The function names are all really
confusing, (the "notmuch-show" prefix doesn't help). So what I'd really
like is something that displays the keybinding and the first line of the
documentation of a function, rather than the function name itself.

> This makes 'x' much the same as 'a', but instead of taking you to the
> next message, it takes you back to the search window instead.

Except that the patch also reverses the current behavior of "a" and
"A". That should be a separate patch anyway, but I'm also not sure that
I like it. I like that the command that takes the extra effort of
pressing shift is the command that does *more*, (removing both "unread"
and "inbox"), rather than the command that does *less*.

-Carl