Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 6CC88431FBC
	for <notmuch@notmuchmail.org>; Tue,  4 Feb 2014 02:31:50 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 9Ed5XVpVfoQc for <notmuch@notmuchmail.org>;
	Tue,  4 Feb 2014 02:31:44 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 8DB3A431FAF
	for <notmuch@notmuchmail.org>; Tue,  4 Feb 2014 02:31:44 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 9BBEF100033;
	Tue,  4 Feb 2014 12:31:36 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: "W. Trevor King" <wking@tremily.us>
Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for
	part buttons
In-Reply-To: <20140204001430.GP14197@odin.tremily.us>
References: <877g9chbay.fsf@qmul.ac.uk>
 <cover.1391423201.git.wking@tremily.us>
	<27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us>
	<m2k3dcq62w.fsf@guru.guru-group.fi>	<20140204001430.GP14197@odin.tremily.us>
User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Tue, 04 Feb 2014 12:31:36 +0200
Message-ID: <m2eh3jp3sn.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2014 10:31:50 -0000

On Tue, Feb 04 2014, "W. Trevor King" <wking@tremily.us> wrote:

> On Mon, Feb 03, 2014 at 10:44:39PM +0200, Tomi Ollila wrote:
>> having notmuch patch email as expected test output feels a bit
>> confusing to me -- especially as 'git grep' may catch some of the
>> (possibly future-outdated) content...
>
> There were two very similar patches with filename attachments in the
> corpus, so I used them for the tests ;).  I can convert that test to
> use emacs_fcc_message or some other auto-generated content if you'd
> prefer.

You're right; corpus seems to be full of notmuch patch emails...


... and (although?) (just noticed)...

$ grep '^ *[+-].*\<if\>' test/* test/*/*
test/emacs.expected-output/attachment:+    if (pw_buf_size == -1)
pw_buf_size = 64;
test/emacs.expected-output/attachment:+    if (pw_buf_size == -1)
pw_buf_size = 64;

... I am not giving much resistance to keep the patch as it is :D

>
> Cheers,
> Trevor
>

Tomi