Return-Path: <bremner@unb.ca>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 92EAD431FB6
	for <notmuch@notmuchmail.org>; Thu, 10 Jan 2013 04:08:43 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id P03OrQb6umU2 for <notmuch@notmuchmail.org>;
	Thu, 10 Jan 2013 04:08:43 -0800 (PST)
Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 18C8A431FAF
	for <notmuch@notmuchmail.org>; Thu, 10 Jan 2013 04:08:43 -0800 (PST)
Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
	([156.34.82.78] helo=zancas.localnet)
	by tesseract.cs.unb.ca with esmtpsa
	(TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
	(envelope-from <bremner@unb.ca>)
	id 1TtGw3-0006Kw-BG; Thu, 10 Jan 2013 08:08:40 -0400
Received: from bremner by zancas.localnet with local (Exim 4.80)
	(envelope-from <bremner@unb.ca>)
	id 1TtGvx-0005jl-M2; Thu, 10 Jan 2013 08:08:33 -0400
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag
In-Reply-To: <m2txqphddd.fsf@guru.guru-group.fi>
References: <1357681314-29384-1-git-send-email-jani@nikula.org>
	<87fw29wwzp.fsf@zancas.localnet>
	<m2txqphddd.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Thu, 10 Jan 2013 08:08:33 -0400
Message-ID: <874nipw88u.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2013 12:08:43 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:
>
> That sure is a good point, should follow-up patch do this:
>
> -    int ret = 0;
> +    int ret = NOTMUCH_STATUS_SUCCESS;
>

sure.

d