From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: test: (gnu) tar(1) portability
In-Reply-To: <87ppny7bdq.fsf@zancas.localnet>
References: <m2mwj2aj9w.fsf@guru.guru-group.fi>
	<87ppny7bdq.fsf@zancas.localnet>
User-Agent: Notmuch/0.17+34~g98b959f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Sun, 19 Jan 2014 15:58:29 +0200
Message-ID: <m2ha906pkq.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Sat, Jan 11 2014, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>
>> 2) Change calls to 'tar' to format ${GNU_TAR:-tar} so testers can set 
>>    environment variable GNU_TAR to the name/path of gnu tar when running
>>    tests (like GNU_TAR=/usr/local/bin/gtar make test or GNU_TAR=gtar ...)
>
> I don't really see any downside to this option; there's only a few calls
> to tar to replace.  Of course we could bikeshed about whether to write 
>
> TAR=${GNU_TAR:-tar}
> ...
>
> ${TAR} --frub --blah 
>
> instead of testing GNU_TAR everywhere.

I also thought of this option, exactly in the same format, too.. 

>
> But, shrug...

Yes... 

and this leads to probably more problematic issue: Mac OS X has
bash version 3 -- which cannot be used to run test scripts. For
that we'd also need a variabe (and some test script trickiness).

This bash issue is easier to solve by tuning the PATH instead of
introducing another variable (or check for 'bash4' existence (ehhe;))
There for we could (that's probably me, then ;/) just document that
in test/README Prerequisites section..

>
> d

Tomi