Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CD7BB429E25 for ; Wed, 1 Jun 2011 16:41:42 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0uIfD4HdTNsb for ; Wed, 1 Jun 2011 16:41:42 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 4E3B9431FB6 for ; Wed, 1 Jun 2011 16:41:42 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 4023329A482; Wed, 1 Jun 2011 16:41:41 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 26E4954C02C; Wed, 1 Jun 2011 16:41:41 -0700 (PDT) From: Carl Worth To: Jameson Graef Rollins , Notmuch Mail Subject: Re: [PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output In-Reply-To: <1306619520-25730-8-git-send-email-jrollins@finestructure.net> References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net> <1306619520-25730-2-git-send-email-jrollins@finestructure.net> <1306619520-25730-3-git-send-email-jrollins@finestructure.net> <1306619520-25730-4-git-send-email-jrollins@finestructure.net> <1306619520-25730-5-git-send-email-jrollins@finestructure.net> <1306619520-25730-6-git-send-email-jrollins@finestructure.net> <1306619520-25730-7-git-send-email-jrollins@finestructure.net> <1306619520-25730-8-git-send-email-jrollins@finestructure.net> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Wed, 01 Jun 2011 16:41:21 -0700 Message-ID: <87ei3dxgpq.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2011 23:41:42 -0000 --=-=-= On Sat, 28 May 2011 14:51:42 -0700, Jameson Graef Rollins wrote: > The test in json was inferior to the one in search-output, since it > wasn't properly testing for the presence of a trailing newline. Hi Jamie, I've pushed the series up to this point now, (along with the vim improvements that weren't in your original mailing of the series). I really appreciate the missing-newline bug-fix along with all the improved testing for that. Thanks! I re-ordered that portion of the patch series a tiny bit to put the bug fix immediately after the commit that makes the tests start failing. I also reworded a few commit messages slightly. But I didn't make any code changes so it's trivial enough for me to keep using "git rebase" to keep your series on top of my modified master. I'll keep posting as I'm pushing. -Carl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3mziEACgkQ6JDdNq8qSWi68QCdG6SrxYTxJku7q+c9GHUgAbjV ugIAn18yU4j7jENuLpRTldhY7HGRFv5e =nLVJ -----END PGP SIGNATURE----- --=-=-=--