Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A820E431FAF for ; Sat, 14 Sep 2013 13:17:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.201 X-Spam-Level: X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IEMLXW6eNOpd for ; Sat, 14 Sep 2013 13:17:14 -0700 (PDT) Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E90B3431FAE for ; Sat, 14 Sep 2013 13:17:13 -0700 (PDT) Received: by mail-we0-f174.google.com with SMTP id q58so2296038wes.5 for ; Sat, 14 Sep 2013 13:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=87O5cfSjAmGkuu+v5mUIJWMfuQP11ZU8eNlNQAm0/Vs=; b=PehO7g5SlWVJ11cr5C6MCo9NrNqKggOxyrSCiweepuAyd4r0GjnuRc68s5wESXE4Xh rGXDUwkFIxL9XP/A4ldZBZcRRSiXJB7fHXy4JlQ0wR87EDnFebTXUApRRn2lF+Ijjkac utUbexaip9VWuGSS11or/8eNPJcz/7lzKyJO7hdz/wfaYqiPsq4tIY0uJAKUv25h83ws cUxMF8NopEu6vUtCj176J1yCXfGxfSBHHKx8Y4bTLv4E614k5TXYvYtzBJdLIE2xzPGz bf5lC4g72CdGUK8q0GOiG9jWgqZtgTEyqeJqwrmPUOI8BT1/tnIxRDFQsIoyuva0c6X2 hTXA== X-Received: by 10.194.24.168 with SMTP id v8mr16225023wjf.28.1379189832779; Sat, 14 Sep 2013 13:17:12 -0700 (PDT) Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) by mx.google.com with ESMTPSA id i8sm12247180wib.1.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 14 Sep 2013 13:17:12 -0700 (PDT) From: Mark Walters To: notmuch@notmuchmail.org Subject: [PATCH] emacs: bugfix unquoted symbol Date: Sat, 14 Sep 2013 21:17:07 +0100 Message-Id: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com> X-Mailer: git-send-email 1.7.9.1 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 20:17:20 -0000 In the recent changes for search order handling the default-value of notmuch-search-oldest-first was used. However, default-value needs a symbol so the symbol-name needs to be quoted. This missing quote was causing strange sort-orders in some cases. --- I think this is clearly correct (and what was intended) and it seems to work as expected. Best wishes Mark emacs/notmuch.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 4de6229..0ff248b 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -888,7 +888,7 @@ the configured default sort order." nil ;; Use the default search order (if we're doing a search from a ;; search buffer, ignore any buffer-local overrides) - (default-value notmuch-search-oldest-first))) + (default-value 'notmuch-search-oldest-first))) (let* ((query (or query (notmuch-read-query "Notmuch search: "))) (buffer (get-buffer-create (notmuch-search-buffer-title query)))) -- 1.7.9.1