From: Tomi Ollila <tomi.ollila@iki.fi>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Add customization group for replying
In-Reply-To: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>
References: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>
User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 06 Sep 2012 11:57:01 +0300
Message-ID: <m2wr07fs0y.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Thu, Sep 06 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:

> When one wants to customize the format of reply message, there is nothing
> to tell the user how to do it.  Without knowing that construction of
> reply buffer is actually implemented in the message package, it seems
> that replying cannot be customized.
>
> Because I was getting annoyed by the empty line the between the citation
> line and the quoted message, I figured out that changing this is fairly
> easy when one knows what to customize.
>
> This patch adds notmuch-reply customization group that contains
> references to the relevant customization options. The new group is easy
> to find as it is shown as a result of running "M-x customize-group RET
> notmuch RET".
> ---

So far good, but...

You forgot to handle the current group setting for 
notmuch-message-replied-tags -- currently notmuch-message.el has this:

(defcustom notmuch-message-replied-tags '("replied")
  "Tags to be automatically added to or removed from a message when it is
  replied to.
Any tag in the list will be added to a replied message or,
if it is prefaced with a \"-\", removed.

For example, if you wanted to add a \"replied\" tag and remove
the \"inbox\" and \"todo\", you would set
    (\"replied\" \"-inbox\" \"-todo\"\)"
  :type 'list
  :group 'notmuch-send)

If the above was changed to 'normuch-send, (require 'notmuch-lib)
was added to the beginning of notmuch-message.el and the defgroup
below was written as

(defgroup notmuch-reply
  '((message-insertion custom-group)))
   "Replying to messages.
    ...

would that work as expected ?

Tomi


>  emacs/notmuch-lib.el |   10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 900235b..c045a32 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -45,6 +45,16 @@
>    "Showing messages and threads."
>    :group 'notmuch)
>  
> +(defgroup notmuch-reply
> +  '((message-insertion custom-group)
> +    (notmuch-message-replied-tags custom-variable))
> +  "Replying to messages.
> +
> +Most of the reply customization settings can be found in `Message
> +insertion' group. Notmuch specific settings is included directly
> +here."
> +  :group 'notmuch)
> +
>  (defgroup notmuch-send nil
>    "Sending messages from Notmuch."
>    :group 'notmuch)
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch