From: Thomas Schwinge <thomas@schwinge.name>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Add a few tests for searching LWN emails.
In-Reply-To: <87vd18n6j9.fsf@yoom.home.cworth.org>
References: <1296124309-20072-1-git-send-email-thomas@schwinge.name>
	<87vd18n6j9.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5-33-g665f77b (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Sun, 30 Jan 2011 12:01:47 +0100
Message-ID: <87y662odt0.fsf@kepler.schwinge.homeip.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hallo!

On Sat, 29 Jan 2011 05:59:38 +1000, Carl Worth <cworth@cworth.org> wrote:
> On Thu, 27 Jan 2011 03:31:49 -0700, Thomas Schwinge <thomas@schwinge.name=
> wrote:
> > These tests should pass -- but they currently don't.

> Thanks for sending these test cases. This is actually my favorite way to
> receive bug reports. I really appreciate it!

I'm doing this for a simple resons: I won't manually have to remember (!)
and later re-run my testings in order to confirm that the issue has been
fixed.  :-)


> So I'm not sure what could reasonably be changed here in GMime or not. I
> definitely do want to fix notmuch so that it indexes all of the text
> here regardless if it's formatted in an RFC-compliant way or not.

Given Matthieu's comment, I wouldn't; as I explained in my reply to his
email.  Now, if this is indeed a GMIME issue -- do we want these tests in
notmuch at all, or should I rather (adapt and) submit them for GMIME?


> [*] Except for test VI which has a bug in that it searches for the word
> "mailing" in the subject header, but no such word exists in the
> message's subject header.

Ack.  Fixed locally.


Gr=C3=BC=C3=9Fe,
 Thomas

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEcBAEBAgAGBQJNRUUbAAoJEGe3hdm9kOii0gsIAMkASbapuzfC8ikhqAhMlp0d
mKQAnP2knECijMjpNlP0sopw3AnSVskINNq151e7xy3AatFpF9MqvJAuyUQZi3py
tnV+4fZYANDzAFd2PSaYNs/f0IH0DIgK3OjTmOIG8PRCm+dDSic/nL/xqAl+Z3Rx
kgbtE46arAfuhfToXLXt3/5ypgB61zsoZtmGY/AH2Xb5JlLAy3YSEic2ZQwLJrj4
euNDXNIFvcFEFuyq1GTsL0k2VjVuogPXHVyzOtvzakjKVLRPES32d//LESdJZPQ2
ULqT0/EXor9FRmVLTiuOORyI3rzmK2xpcL6Nf+mN1vAndiM5rL0svJ5ROkCOPQM=
=kmTW
-----END PGP SIGNATURE-----
--=-=-=--