Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Justus Winter <4winter@informatik.uni-hamburg.de>
User-Agent: alot/0.3+
To: Tomi Ollila <tomi.ollila@iki.fi>, Austin Clements <amdragon@MIT.EDU>,
	notmuch@notmuchmail.org
References: <1336939029-13969-1-git-send-email-amdragon@mit.edu>
	<m2txzjlsax.fsf@guru.guru-group.fi>
In-Reply-To: <m2txzjlsax.fsf@guru.guru-group.fi>
Message-ID: <20120513215538.15106.43740@thinkbox.jade-hamburg.de>
Subject: Re: [PATCH 0/5] Fix notmuch_database_get_directory API
Date: Sun, 13 May 2012 23:55:38 +0200
Precedence: list

Quoting Tomi Ollila (2012-05-13 22:49:58)
> On Sun, May 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> =

> > This is a proposed last-minute change for 0.13.  It fixes the
> > notmuch_database_get_directory API in the same way we're fixing
> > notmuch_database_open, etc in this release.  Since this is a
> > backwards-incompatible change, it would be nice to lump it with the
> > other API-breaking changes.
> >
> > To keep the patch simple, this does not change the behavior of
> > notmuch_database_get_directory, but it puts us in a good position to
> > fix it in the future.
> =

> Looks good to me (and applied in my current environment). The c/c++ =

> changes were easy to understand and the python/go/ruby binding
> changes looks like the old changes -- but those who understand more
> (and actually uses those bindings) could do better review.

I'd say the changes to the python and go bindings are fine.

> It would be nice to get those in so that we may have chance not
> updating SONAME for notmuch 0.14.

Yes, I'd love to see this in 0.13 as well, but I don't really see the
problem with breaking the api if this fixes design issues. After all,
notmuch is young and so are all the projects building uppon it.

Justus