Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 23672431FAF for ; Sun, 19 Feb 2012 10:05:23 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WCF-W-tmiGg1 for ; Sun, 19 Feb 2012 10:05:22 -0800 (PST) Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU [18.9.25.13]) by olra.theworths.org (Postfix) with ESMTP id A445D431FAE for ; Sun, 19 Feb 2012 10:05:22 -0800 (PST) X-AuditID: 1209190d-b7fbf6d0000008ba-eb-4f4139e28851 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id 1F.07.02234.2E9314F4; Sun, 19 Feb 2012 13:05:22 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q1JI5LVX020545; Sun, 19 Feb 2012 13:05:22 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1JI5KN8013954 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sun, 19 Feb 2012 13:05:20 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1RzB6f-0007Xa-Lu; Sun, 19 Feb 2012 13:03:29 -0500 Date: Sun, 19 Feb 2012 13:03:29 -0500 From: Austin Clements To: Dmitry Kurochkin Subject: Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default Message-ID: <20120219180329.GR5991@mit.edu> References: <1329632533-16152-1-git-send-email-amdragon@mit.edu> <20120219172541.GQ5991@mit.edu> <87zkceloiz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zkceloiz.fsf@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsUixCmqrPvI0tHfYMUJLourW/vZLa7fnMls 8WblPFYHZo+ds+6yexz+upDF49mqW8wBzFFcNimpOZllqUX6dglcGWe3LWUtuMddsWrCDpYG xkmcXYycHBICJhLTFx9hh7DFJC7cW8/WxcjFISSwj1Hi8//HjBDOBkaJhol/2CGck0wSB3bv ZoVwljBKPJkymxWkn0VAVaLv134wm01AQ2Lb/uWMILaIgKHErYuvmLsYOTiYBWwlpl6JAQkL CwRKzHs/BWw1r4C2xNHDr6EWLGWUWHt7BytEQlDi5MwnLCA2s4CWxI1/L5kg5khLLP/HARLm FFCX+PfhIRuILSqgIjHl5Da2CYxCs5B0z0LSPQuhewEj8ypG2ZTcKt3cxMyc4tRk3eLkxLy8 1CJdI73czBK91JTSTYzgYJfk3cH47qDSIUYBDkYlHl7JMgd/IdbEsuLK3EOMkhxMSqK8POaO /kJ8SfkplRmJxRnxRaU5qcWHGCU4mJVEeEtv2vsL8aYkVlalFuXDpKQ5WJTEeVW13vkJCaQn lqRmp6YWpBbBZGU4OJQkeGOBUS0kWJSanlqRlplTgpBm4uAEGc4DNFwUpIa3uCAxtzgzHSJ/ ilGX4+OBJxcYhVjy8vNSpcR5vUCKBECKMkrz4ObAktQrRnGgt4R540CqeIAJDm7SK6AlTEBL eIXsQJaUJCKkpBoY5WZJFb3Y1mrB/qfIUTvJQCr7v+nhIv6Hvzj+M5/SdD/+f57ztZ7PdWZe oouL/83a7XXHpfrC8VeXS1X61qxcqauTbGl119/nYFXcLlbx02t11ig/nVw289CW2etX+zId 3eYn7DPvW+q00AdcWyLXL13aHvvQ+O0Rs9tuoi6GTPkzjt5dW+X6UImlOCPRUIu5qDgRAKpm FtktAwAA Cc: Tomi Ollila , notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Feb 2012 18:05:23 -0000 Quoth Dmitry Kurochkin on Feb 19 at 9:29 pm: > On Sun, 19 Feb 2012 12:25:41 -0500, Austin Clements wrote: > > Quoth Tomi Ollila on Feb 19 at 11:43 am: > > > On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements wrote: > > > > Based on the thread at id:"20120213152858.GO27039@mit.edu" it seems > > > > like people want show refresh to retain message state by default (I > > > > certainly do), rather than reset it by default. As a nice bonus, this > > > > fixes a broken test. > > > > > > Hmm > > > > > > Every '=' keypress in a thread removes 'unread' tag from next unread > > > message :o > > > > Oh dear. It's slightly subtler than that, though. Refreshing will > > remove the unread tag from the first message matching the query. (I > > suspect you had tag:unread in your query?) This is particularly > > confusing for state-retaining refresh because that message might not > > even be open. > > > > > That is probably desirable feature when refreshing view without > > > retaining state. Also, probably notmuch-show-refresh-view should > > > be fixed not to mark next message unread when retaining state ? > > > > I would argue that refresh should never have side-effects, so neither > > case should mark anything read. I'll send a v2. > > I agree. But this looks like a separate issue, no? So why v2 instead > of a separate patch/series? I wanted to slip it in before inverting the default behavior of refresh.