Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id C041E6DE0222 for ; Fri, 15 Apr 2016 03:29:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.017 X-Spam-Level: X-Spam-Status: No, score=-0.017 tagged_above=-999 required=5 tests=[AWL=-0.006, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hj9QQ8YlZOKl for ; Fri, 15 Apr 2016 03:29:24 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 6D9796DE00F5 for ; Fri, 15 Apr 2016 03:29:24 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84) (envelope-from ) id 1ar10A-0004mB-U7; Fri, 15 Apr 2016 06:29:26 -0400 Received: (nullmailer pid 8795 invoked by uid 1000); Fri, 15 Apr 2016 10:29:16 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Cc: Austin Clements Subject: Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists In-Reply-To: <87wpo362er.fsf@zancas.localnet> References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net> <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net> <87r3ed6l35.fsf@zancas.localnet> <87zit0t0mj.fsf@alice.fifthhorseman.net> <87wpo362er.fsf@zancas.localnet> User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 15 Apr 2016 07:29:16 -0300 Message-ID: <87potri2rn.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 10:29:32 -0000 David Bremner writes: > Daniel Kahn Gillmor writes: > > >> I don't think this reasoning is sensible. If the entire thread is >> deleted, and a new message comes in, it should *not* get the same mesage >> ID. ghosts should only exist in the database when other messages point >> to them. >> >> So i'd be fine with killing this entire last test, unless someone can >> propose a good reason to keep it. > > I think I buy your reasoning, but I'd be happy if Austin (who introduced > ghost messages, and wrote that test, could comment. I have pushed the series, amended to remove that one test from T530. d