From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't record undo information for search or show
	buffers.
In-Reply-To: <1321837255-8669-1-git-send-email-amdragon@mit.edu>
References: <1321837255-8669-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.10~rc1+20~gec94ced (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 21 Nov 2011 05:07:15 +0400
Message-ID: <87d3cmp9ks.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Sun, 20 Nov 2011 20:00:55 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> There's no reason to record undo information for read-only,
> programmatically-constructed buffers.  The undo list just chews up
> memory keeping track of our calls to insert.

Makes sense and looks good!

Regards,
  Dmitry

> ---
>  emacs/notmuch-show.el |    2 ++
>  emacs/notmuch.el      |    2 ++
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index d5c95d8..7689867 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -843,6 +843,8 @@ buffer."
>  	 (inhibit-read-only t))
>      (switch-to-buffer buffer)
>      (notmuch-show-mode)
> +    ;; Don't track undo information for this buffer
> +    (set 'buffer-undo-list t)
>  
>      (setq notmuch-show-thread-id thread-id)
>      (setq notmuch-show-parent-buffer parent-buffer)
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index c1827cc..a8e4d62 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -920,6 +920,8 @@ The optional parameters are used as follows:
>    (let ((buffer (get-buffer-create (notmuch-search-buffer-title query))))
>      (switch-to-buffer buffer)
>      (notmuch-search-mode)
> +    ;; Don't track undo information for this buffer
> +    (set 'buffer-undo-list t)
>      (set 'notmuch-search-query-string query)
>      (set 'notmuch-search-oldest-first oldest-first)
>      (set 'notmuch-search-target-thread target-thread)
> -- 
> 1.7.7.2
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch