Date: Mon, 18 Jan 2016 12:45:12 +0000
From: Gaute Hope <eg@gaute.vetsj.com>
Subject: Re: talloc_abort in notmuch_thread_get_tags () when db has been
 modified
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
References: 
In-Reply-To: 
User-Agent: astroid/vv0.4-213-g53abb3e2 (https://github.com/gauteh/astroid)
Message-Id: <1453121100-astroid-2-c62fwcrm91-18877@strange>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: list

David Bremner writes on January 18, 2016 13:25:
> The most likely cause of such a crash looks to me like nm_thread is NULL
> or corrupted when passed in to get_tags. It's used without checking as a
> talloc context, and that call to talloc never returns.
>

Ok, I'll check some further. I am checking whether nm_thread is NULL
though, the preceding code is as follows
(astroid/src/modes/thread_index/thread_index.cc:258):

```
    for (;
         notmuch_threads_valid (threads);
         notmuch_threads_move_to_next (threads)) {

      notmuch_thread_t  * thread;
      thread =3D notmuch_threads_get (threads);

      if (thread =3D=3D NULL) {
        log << error << "ti: error: could not get thread." << endl;
        throw database_error ("ti: could not get thread (is NULL)");
      }

      /* test for revision discarded */
      const char * ti =3D notmuch_thread_get_thread_id (thread);
      if (ti =3D=3D NULL) {
        log << error << "ti: revision discarded, trying to reopen." << endl=
;
        reopen_tries++;
        refresh (all, current_thread + count, false);
        return;
      }


      NotmuchThread *t =3D new NotmuchThread (thread); // get_tags is insid=
e here

      notmuch_thread_destroy (thread);

```

(note that there is a bit of code there trying to determine whether the
db is still valid, or needs to be re-opened)

- g
=