Return-Path: <cworth@cworth.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id CF3D94196F0
	for <notmuch@notmuchmail.org>; Tue, 27 Apr 2010 08:29:04 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.89
X-Spam-Level: 
X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
	tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
	autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 2jgtsGZqhBbd; Tue, 27 Apr 2010 08:29:04 -0700 (PDT)
Received: from yoom.home.cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 13DC6431FC1;
	Tue, 27 Apr 2010 08:29:04 -0700 (PDT)
Received: by yoom.home.cworth.org (Postfix, from userid 1000)
	id AFE2C568DEB; Tue, 27 Apr 2010 08:29:03 -0700 (PDT)
From: Carl Worth <cworth@cworth.org>
To: Jesse Rosenthal <jrosenthal@jhu.edu>,
	Notmuch developer list <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/2] emacs: Add auto-tagging for replied messages.
In-Reply-To: <87d3xlkpsc.fsf@jhu.edu>
References: <87d3xlkpsc.fsf@jhu.edu>
User-Agent: Notmuch/0.2-251-g8514e59 (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Tue, 27 Apr 2010 08:29:03 -0700
Message-ID: <87fx2gnccg.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Apr 2010 15:29:05 -0000

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 27 Apr 2010 09:06:59 -0400, Jesse Rosenthal <jrosenthal@jhu.edu> wr=
ote:
> Add `notmuch-message-mark-replied', a function for automatically tagging
> replied messages with user-defined tags.

A nice, feature. Thanks!

A couple of points on the patch:

> +(defcustom notmuch-message-replied-tags '("replied")
> +  "A set of tags to be added or, if prefaced with a `-', removed. For=20
> +example, \(\"replied\" \"-inbox\" \"-todo\"\)"

This documentation string needs to be improved a bit. Look in customize
and see if only the first line appears by default. If so, we don't want
a widowed "For" at the end of the line.

Also, this documentation string doesn't actually give a new user enough
information to learn what this actually does.

Should say something like:

"Tags to be added/removed from messages when sending a reply to that messag=
e."

as the first sentence. That tells the user what the feature does and
whether it's interesting. If so, the user can expand the documentation
and subsequent sentences can explain things like '-', etc.

Finally, since this is a new feature it needs to add a new blurb to the
NEWS file.

Thanks,

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFL1wK/6JDdNq8qSWgRAvR8AJwPhGh2Js5N6wu4ydvopQhCnKemqwCfcdQc
cBc5vnzMpb7IKOUJFSDhd4s=
=UWhW
-----END PGP SIGNATURE-----
--=-=-=--