Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 035B96DE012F for ; Sat, 6 Aug 2016 12:45:41 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.564 X-Spam-Level: X-Spam-Status: No, score=0.564 tagged_above=-999 required=5 tests=[AWL=-0.088, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XVVGSHudLXMm for ; Sat, 6 Aug 2016 12:45:31 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 5DE236DE00DF for ; Sat, 6 Aug 2016 12:45:31 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 9508510005A; Sat, 6 Aug 2016 22:45:06 +0300 (EEST) From: Tomi Ollila To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] emacs: wash: word-wrap bugfix and tweak In-Reply-To: <1470497374-17194-1-git-send-email-markwalters1009@gmail.com> References: <1470497374-17194-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.22+56~ge2391a7 (https://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Aug 2016 19:45:41 -0000 On Sat, Aug 06 2016, Mark Walters wrote: > Jani pointed out on irc that there was a bug in notmuch-tree that when > a message very deep in a thread is viewed in the message pane it is > wordwrapped too soon. > > This is actually a bug in notmuch-wash: it assumes that > notmuch-show-indent-messages-width is 1, so that the indentation of > the message is equal to its depth in the thread. > > The first patch fixes the bug, and uses the correct indentation. > > The second patch is a version of > id:1467791251-6823-1-git-send-email-markwalters1009@gmail.com on > on top of the first patch above. > > The first patch is a clear bugfix and can be applied on its own. > > The second is a change; I think the new version is the natural > interpretation of notmuch-word-wrap-lines-length so have removed the > old behaviour. See the message > id:1467791251-6823-1-git-send-email-markwalters1009@gmail.com for more > details of the change. The bugfix and the change both looks good to me. I have not (yet) tested these for the time being... Tomi > > Best wishes > > Mark > > > > > > Mark Walters (2): > emacs: wash: word-wrap bugfix > emacs: wash: make word-wrap bound message width > > emacs/notmuch-wash.el | 10 ++++++---- > ...w-thread-maildir-storage-with-fourfold-indentation | 19 ++++++++++++------- > ...ch-show-thread-maildir-storage-without-indentation | 8 ++++---- > 3 files changed, 22 insertions(+), 15 deletions(-) > > -- > 2.1.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch